Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: Source/core/editing/AppendNodeCommand.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/shadow/ShadowRoot.cpp ('k') | Source/core/editing/InsertNodeBeforeCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 22 matching lines...) Expand all
33 33
34 AppendNodeCommand::AppendNodeCommand(PassRefPtr<ContainerNode> parent, PassRefPt r<Node> node) 34 AppendNodeCommand::AppendNodeCommand(PassRefPtr<ContainerNode> parent, PassRefPt r<Node> node)
35 : SimpleEditCommand(parent->document()) 35 : SimpleEditCommand(parent->document())
36 , m_parent(parent) 36 , m_parent(parent)
37 , m_node(node) 37 , m_node(node)
38 { 38 {
39 ASSERT(m_parent); 39 ASSERT(m_parent);
40 ASSERT(m_node); 40 ASSERT(m_node);
41 ASSERT(!m_node->parentNode()); 41 ASSERT(!m_node->parentNode());
42 42
43 ASSERT(m_parent->rendererIsEditable() || !m_parent->attached()); 43 ASSERT(m_parent->rendererIsEditable() || !m_parent->confusingAndOftenMisused Attached());
44 } 44 }
45 45
46 void AppendNodeCommand::doApply() 46 void AppendNodeCommand::doApply()
47 { 47 {
48 if (!m_parent->rendererIsEditable() && m_parent->attached()) 48 if (!m_parent->rendererIsEditable() && m_parent->confusingAndOftenMisusedAtt ached())
49 return; 49 return;
50 50
51 m_parent->appendChild(m_node.get(), IGNORE_EXCEPTION); 51 m_parent->appendChild(m_node.get(), IGNORE_EXCEPTION);
52 } 52 }
53 53
54 void AppendNodeCommand::doUnapply() 54 void AppendNodeCommand::doUnapply()
55 { 55 {
56 if (!m_parent->rendererIsEditable()) 56 if (!m_parent->rendererIsEditable())
57 return; 57 return;
58 58
59 m_node->remove(IGNORE_EXCEPTION); 59 m_node->remove(IGNORE_EXCEPTION);
60 } 60 }
61 61
62 } // namespace WebCore 62 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/shadow/ShadowRoot.cpp ('k') | Source/core/editing/InsertNodeBeforeCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698