Rename Node::attached() to confusingAndOftenMisusedAttached()

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 1531 matching lines @@
 
     ASSERT(needsStyleRecalc() || childNeedsStyleRecalc() || childNeedsDistributionRecalc());
 
     m_styleRecalcTimer.startOneShot(0);
 
     InspectorInstrumentation::didScheduleStyleRecalculation(this);
 }
 
 void Document::unscheduleStyleRecalc()
 {
-    ASSERT(!attached() || (!needsStyleRecalc() && !childNeedsStyleRecalc()));
+    ASSERT(!confusingAndOftenMisusedAttached() || (!needsStyleRecalc() && !childNeedsStyleRecalc()));
     m_styleRecalcTimer.stop();
 }
 
 bool Document::hasPendingStyleRecalc() const
 {
     return m_styleRecalcTimer.isActive() && !m_inStyleRecalc;
 }
 
 bool Document::hasPendingForcedStyleRecalc() const
 {
@@ skipping 412 matching lines @@
     m_styleEngine->combineCSSFeatureFlags(m_styleResolver->ruleFeatureSet());
 }
 
 void Document::clearStyleResolver()
 {
     m_styleResolver.clear();
 }
 
 void Document::attach(const AttachContext& context)
 {
-    ASSERT(!attached());
+    ASSERT(!confusingAndOftenMisusedAttached());
     ASSERT(!m_axObjectCache || this != topDocument());
 
     // Create the rendering tree
     setRenderer(new RenderView(this));
     renderView()->setIsInWindow(true);
 
     recalcStyle(Force);
 
     ContainerNode::attach(context);
 }
 
 void Document::detach(const AttachContext& context)
 {
-    ASSERT(attached());
+    ASSERT(confusingAndOftenMisusedAttached());
 
     if (page())
         page()->documentDetached(this);
 
     if (this == topDocument())
         clearAXObjectCache();
 
     stopActiveDOMObjects();
     m_eventQueue->close();
 
@@ skipping 10 matching lines @@
     documentWillBecomeInactive();
 
     SharedWorkerRepository::documentDetached(this);
 
     if (m_frame) {
         FrameView* view = m_frame->view();
         if (view)
             view->detachCustomScrollbars();
     }
 
-    // indicate destruction mode,  i.e. attached() but renderer == 0
+    // indicate destruction mode, i.e. confusingAndOftenMisusedAttached() but renderer == 0
     setRenderer(0);
 
     m_hoverNode = 0;
     m_focusedElement = 0;
     m_activeElement = 0;
 
     ContainerNode::detach(context);
 
     unscheduleStyleRecalc();
 
@@ skipping 17 matching lines @@
 
     lifecycleNotifier()->notifyDocumentWasDetached();
 }
 
 void Document::prepareForDestruction()
 {
     disconnectDescendantFrames();
 
     // The process of disconnecting descendant frames could have already
     // detached us.
-    if (!attached())
+    if (!confusingAndOftenMisusedAttached())
         return;
 
     if (DOMWindow* window = this->domWindow())
         window->willDetachDocumentFromFrame();
     detach();
 }
 
 void Document::removeAllEventListeners()
 {
     EventTarget::removeAllEventListeners();
@@ skipping 1202 matching lines @@
 void Document::evaluateMediaQueryList()
 {
     if (m_mediaQueryMatcher)
         m_mediaQueryMatcher->styleResolverChanged();
 }
 
 void Document::styleResolverChanged(StyleResolverUpdateType updateType, StyleResolverUpdateMode updateMode)
 {
     // Don't bother updating, since we haven't loaded all our style info yet
     // and haven't calculated the style selector for the first time.
-    if (!attached() || (!m_didCalculateStyleResolver && !haveStylesheetsLoaded())) {
+    if (!confusingAndOftenMisusedAttached() || (!m_didCalculateStyleResolver && !haveStylesheetsLoaded())) {
         m_styleResolver.clear();
         return;
     }
     m_didCalculateStyleResolver = true;
 
     bool needsRecalc = m_styleEngine->updateActiveStyleSheets(updateMode);
 
     if (didLayoutWithPendingStylesheets() && !m_styleEngine->hasPendingSheets()) {
         // We need to manually repaint because we avoid doing all repaints in layout or style
         // recalc while sheets are still loading to avoid FOUC.
@@ skipping 2147 matching lines @@
 {
     return DocumentLifecycleNotifier::create(this);
 }
 
 DocumentLifecycleNotifier* Document::lifecycleNotifier()
 {
     return static_cast<DocumentLifecycleNotifier*>(ScriptExecutionContext::lifecycleNotifier());
 }
 
 } // namespace WebCore