Source/core/dom/ContainerNode.h - Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.h

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/ContainerNode.h

diff --git a/Source/core/dom/ContainerNode.h b/Source/core/dom/ContainerNode.h

index 80b9c88c0ab865503673206d6d3bd014a70fc0ea..a1c0cf86266cb9eb20d42c39a2596fb455365a07 100644

--- a/Source/core/dom/ContainerNode.h

+++ b/Source/core/dom/ContainerNode.h

@@ -190,8 +190,8 @@ inline void ContainerNode::attachChildren(const AttachContext& context)

childrenContext.resolvedStyle = 0;

for (Node* child = firstChild(); child; child = child->nextSibling()) {

- ASSERT(!child->attached() || childAttachedAllowedWhenAttachingChildren(this));

- if (!child->attached())

+ ASSERT(!child->confusingAndOftenMisusedAttached() || childAttachedAllowedWhenAttachingChildren(this));

+ if (!child->confusingAndOftenMisusedAttached())

child->attach(childrenContext);

}