Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 } 413 }
414 414
415 RefPtr<InputType> newType = InputType::create(this, newTypeName); 415 RefPtr<InputType> newType = InputType::create(this, newTypeName);
416 removeFromRadioButtonGroup(); 416 removeFromRadioButtonGroup();
417 417
418 bool didStoreValue = m_inputType->storesValueSeparateFromAttribute(); 418 bool didStoreValue = m_inputType->storesValueSeparateFromAttribute();
419 bool didRespectHeightAndWidth = m_inputType->shouldRespectHeightAndWidthAttr ibutes(); 419 bool didRespectHeightAndWidth = m_inputType->shouldRespectHeightAndWidthAttr ibutes();
420 420
421 m_inputType->destroyShadowSubtree(); 421 m_inputType->destroyShadowSubtree();
422 422
423 bool wasAttached = attached(); 423 bool wasAttached = confusingAndOftenMisusedAttached();
424 if (wasAttached) 424 if (wasAttached)
425 detach(); 425 detach();
426 426
427 m_inputType = newType.release(); 427 m_inputType = newType.release();
428 if (hasAuthorShadowRoot()) 428 if (hasAuthorShadowRoot())
429 m_inputTypeView = InputTypeView::create(this); 429 m_inputTypeView = InputTypeView::create(this);
430 else 430 else
431 m_inputTypeView = m_inputType; 431 m_inputTypeView = m_inputType;
432 m_inputType->createShadowSubtree(); 432 m_inputType->createShadowSubtree();
433 433
(...skipping 1438 matching lines...) Expand 10 before | Expand all | Expand 10 after
1872 } 1872 }
1873 1873
1874 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1874 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1875 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1875 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1876 { 1876 {
1877 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1877 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1878 } 1878 }
1879 #endif 1879 #endif
1880 1880
1881 } // namespace 1881 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFormControlElementWithState.cpp ('k') | Source/core/html/HTMLLIElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698