Source/core/editing/InsertNodeBeforeCommand.cpp - Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertNodeBeforeCommand.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/InsertNodeBeforeCommand.cpp

diff --git a/Source/core/editing/InsertNodeBeforeCommand.cpp b/Source/core/editing/InsertNodeBeforeCommand.cpp

index 16ff925d004a1db43a178e741d6e3857ea56d56b..d30ea733721ef69b4fc460bd9f0c5e6f28b61708 100644

--- a/Source/core/editing/InsertNodeBeforeCommand.cpp

+++ b/Source/core/editing/InsertNodeBeforeCommand.cpp

@@ -43,7 +43,7 @@ InsertNodeBeforeCommand::InsertNodeBeforeCommand(PassRefPtr<Node> insertChild, P

ASSERT(m_refChild);

ASSERT(m_refChild->parentNode());

- ASSERT(m_refChild->parentNode()->rendererIsEditable() || !m_refChild->parentNode()->attached());

+ ASSERT(m_refChild->parentNode()->rendererIsEditable() || !m_refChild->parentNode()->confusingAndOftenMisusedAttached());

}

void InsertNodeBeforeCommand::doApply()

« no previous file with comments | « Source/core/editing/AppendNodeCommand.cpp ('k') | Source/core/editing/RemoveNodeCommand.cpp » ('j') | no next file with comments »