Source/core/html/HTMLFormControlElementWithState.cpp - Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElementWithState.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFormControlElementWithState.cpp

diff --git a/Source/core/html/HTMLFormControlElementWithState.cpp b/Source/core/html/HTMLFormControlElementWithState.cpp

index 0b62d22515551f451f44586544b6ca2d8f79df57..1428787702a9d79032fa0943f9b69883a60645b1 100644

--- a/Source/core/html/HTMLFormControlElementWithState.cpp

+++ b/Source/core/html/HTMLFormControlElementWithState.cpp

@@ -77,7 +77,7 @@ void HTMLFormControlElementWithState::notifyFormStateChanged()

bool HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState() const

{

// We don't save/restore control state in a form with autocomplete=off.

- return attached() && shouldAutocomplete();

+ return confusingAndOftenMisusedAttached() && shouldAutocomplete();

}

FormControlState HTMLFormControlElementWithState::saveFormControlState() const

« no previous file with comments | « Source/core/editing/RemoveNodeCommand.cpp ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »