Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Side by Side Diff: Source/core/svg/SVGUseElement.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGTests.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
6 * Copyright (C) 2012 University of Szeged 6 * Copyright (C) 2012 University of Szeged
7 * Copyright (C) 2012 Renata Hodovan <reni@webkit.org> 7 * Copyright (C) 2012 Renata Hodovan <reni@webkit.org>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 for (SVGElementInstance* current = instance->firstChild(); current; current = current->nextSibling()) { 884 for (SVGElementInstance* current = instance->firstChild(); current; current = current->nextSibling()) {
885 if (SVGElementInstance* search = instanceForShadowTreeElement(element, c urrent)) 885 if (SVGElementInstance* search = instanceForShadowTreeElement(element, c urrent))
886 return search; 886 return search;
887 } 887 }
888 888
889 return 0; 889 return 0;
890 } 890 }
891 891
892 void SVGUseElement::invalidateShadowTree() 892 void SVGUseElement::invalidateShadowTree()
893 { 893 {
894 if (!attached() || m_needsShadowTreeRecreation) 894 if (!confusingAndOftenMisusedAttached() || m_needsShadowTreeRecreation)
895 return; 895 return;
896 m_needsShadowTreeRecreation = true; 896 m_needsShadowTreeRecreation = true;
897 setNeedsStyleRecalc(); 897 setNeedsStyleRecalc();
898 invalidateDependentShadowTrees(); 898 invalidateDependentShadowTrees();
899 } 899 }
900 900
901 void SVGUseElement::invalidateDependentShadowTrees() 901 void SVGUseElement::invalidateDependentShadowTrees()
902 { 902 {
903 // Recursively invalidate dependent <use> shadow trees 903 // Recursively invalidate dependent <use> shadow trees
904 const HashSet<SVGElementInstance*>& instances = instancesForElement(); 904 const HashSet<SVGElementInstance*>& instances = instancesForElement();
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
992 992
993 if (m_resource) 993 if (m_resource)
994 m_resource->removeClient(this); 994 m_resource->removeClient(this);
995 995
996 m_resource = resource; 996 m_resource = resource;
997 if (m_resource) 997 if (m_resource)
998 m_resource->addClient(this); 998 m_resource->addClient(this);
999 } 999 }
1000 1000
1001 } 1001 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGTests.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698