Rename Node::attached() to confusingAndOftenMisusedAttached()

Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 712 matching lines @@
 }
 
 void Node::derefEventTarget()
 {
     deref();
 }
 
 void Node::setNeedsStyleRecalc(StyleChangeType changeType, StyleChangeSource source)
 {
     ASSERT(changeType != NoStyleChange);
-    if (!attached()) // changed compared to what?
+    if (!confusingAndOftenMisusedAttached()) // changed compared to what?
         return;
 
     if (source == StyleChangeFromRenderer)
         setFlag(NotifyRendererWithIdenticalStyles);
 
     StyleChangeType existingChangeType = styleChangeType();
     if (changeType > existingChangeType)
         setStyleChange(changeType);
 
     if (existingChangeType == NoStyleChange)
@@ skipping 209 matching lines @@
             node->clearAttached();
             node->clearChildNeedsStyleRecalc();
 
             for (ShadowRoot* shadowRoot = node->youngestShadowRoot(); shadowRoot; shadowRoot = shadowRoot->olderShadowRoot())
                 detachNode(shadowRoot, context);
 
             node = NodeTraversal::next(node, root);
             continue;
         }
         // Handle normal reattaches from style recalc (ex. display type changes)
-        if (node->attached())
+        if (node->confusingAndOftenMisusedAttached())
             node->detach(context);
         node = NodeTraversal::nextSkippingChildren(node, root);
     }
 }
 
 void Node::reattach(const AttachContext& context)
 {
     AttachContext reattachContext(context);
     reattachContext.performingReattach = true;
 
     detachNode(this, reattachContext);
     attach(reattachContext);
 }
 
 void Node::attach(const AttachContext&)
 {
     ASSERT(document().inStyleRecalc() || isDocumentNode());
-    ASSERT(!attached());
+    ASSERT(!confusingAndOftenMisusedAttached());
     ASSERT(!renderer() || (renderer()->style() && (renderer()->parent() || renderer()->isRenderView())));
 
     setAttached();
     clearNeedsStyleRecalc();
 
     if (Document* doc = documentInternal()) {
         if (AXObjectCache* cache = doc->axObjectCache())
             cache->updateCacheAfterNodeIsAttached(this);
     }
 }
@@ skipping 1660 matching lines @@
         node->showTreeForThis();
 }
 
 void showNodePath(const WebCore::Node* node)
 {
     if (node)
         node->showNodePathForThis();
 }
 
 #endif