Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 10795013: Rename bounds accessors to be intuitive and consistent (Closed)

Created:
8 years, 5 months ago by oshima
Modified:
8 years, 5 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, jeremya+watch_chromium.org, dcheng, alicet1, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, msw+watch_chromium.org, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, jennb, penghuang+watch_chromium.org, jianli, oshima+watch_chromium.org, mihaip-chromium-reviews_chromium.org, tfarina, Dmitry Titov, Aaron Boodman, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename bounds accessors to be intuitive and consistent GetClientAreaScreenBounds -> GetClientAreaBoundsInScreen Get/Set ParentBounds -> Get/Set BoundsInParent GetWorkAreaScreenBounds -> GetWorkAreaBoundsInScreen GetClientAreaScreenBounds -> GetClientAreaBoundsInScreen GetWindowScreenBounds -> GetWindowBoundsInScreen GetScreenBounds -> GetBoundsInScreen GetRootWindowBounds -> GetBoundsInRootWindow BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147499

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -264 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/drag_drop/drag_image_view.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M ash/drag_drop/drag_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/launcher/launcher_view_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/root_window_controller_unittest.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M ash/screen_ash.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/screen_ash.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M ash/screen_ash_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ash/shell_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/base_layout_manager.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/base_layout_manager_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M ash/wm/custom_frame_view_ash_unittest.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M ash/wm/frame_painter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panel_layout_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/panel_layout_manager_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 11 chunks +16 lines, -14 lines 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/toplevel_window_event_filter_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/workspace/maximized_workspace.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/snap_sizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_menu_button_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/panel_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/web_dialog_view_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/window.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/oak/oak_aura_window_display.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/widget_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_private.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
oshima
8 years, 5 months ago (2012-07-18 18:11:00 UTC) #1
sky
LGTM
8 years, 5 months ago (2012-07-18 20:59:28 UTC) #2
oshima
+davemoore for chrome/browser/chromeos/status and chrome/browser/chromeos/login
8 years, 5 months ago (2012-07-18 21:12:23 UTC) #3
whywhat
chromeos/login lgtm
8 years, 5 months ago (2012-07-19 17:05:02 UTC) #4
stevenjb
lgtm
8 years, 5 months ago (2012-07-19 17:05:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10795013/8002
8 years, 5 months ago (2012-07-19 17:06:05 UTC) #6
commit-bot: I haz the power
Presubmit check for 10795013-8002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-19 17:06:56 UTC) #7
Jói
LGTM for content/port.
8 years, 5 months ago (2012-07-19 17:10:51 UTC) #8
oshima
joi -> content/port
8 years, 5 months ago (2012-07-19 17:10:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10795013/8002
8 years, 5 months ago (2012-07-19 17:11:23 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 19:17:07 UTC) #11
Change committed as 147499

Powered by Google App Engine
This is Rietveld 408576698