Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: ash/wm/base_layout_manager_unittest.cc

Issue 10795013: Rename bounds accessors to be intuitive and consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/base_layout_manager.cc ('k') | ash/wm/custom_frame_view_ash_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/base_layout_manager_unittest.cc
diff --git a/ash/wm/base_layout_manager_unittest.cc b/ash/wm/base_layout_manager_unittest.cc
index 5d48392e13aacc430a8cb7b6cb8bc240b4b0fc42..47f1306eab0bd697017cfcc7ccf93296ecd89a59 100644
--- a/ash/wm/base_layout_manager_unittest.cc
+++ b/ash/wm/base_layout_manager_unittest.cc
@@ -55,7 +55,7 @@ TEST_F(BaseLayoutManagerTest, Maximize) {
window->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_MAXIMIZED);
// Maximized window fills the work area, not the whole display.
EXPECT_EQ(
- ScreenAsh::GetMaximizedWindowParentBounds(window.get()).ToString(),
+ ScreenAsh::GetMaximizedWindowBoundsInParent(window.get()).ToString(),
window->bounds().ToString());
window->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_NORMAL);
EXPECT_EQ(bounds.ToString(), window->bounds().ToString());
@@ -79,15 +79,16 @@ TEST_F(BaseLayoutManagerTest, MaximizeRootWindowResize) {
scoped_ptr<aura::Window> window(CreateTestWindow(bounds));
window->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_MAXIMIZED);
gfx::Rect initial_work_area_bounds =
- ScreenAsh::GetMaximizedWindowParentBounds(window.get());
+ ScreenAsh::GetMaximizedWindowBoundsInParent(window.get());
EXPECT_EQ(initial_work_area_bounds.ToString(), window->bounds().ToString());
// Enlarge the root window. We should still match the work area size.
Shell::GetPrimaryRootWindow()->SetHostSize(gfx::Size(900, 700));
EXPECT_EQ(
- ScreenAsh::GetMaximizedWindowParentBounds(window.get()).ToString(),
+ ScreenAsh::GetMaximizedWindowBoundsInParent(window.get()).ToString(),
window->bounds().ToString());
- EXPECT_NE(initial_work_area_bounds.ToString(),
- ScreenAsh::GetMaximizedWindowParentBounds(window.get()).ToString());
+ EXPECT_NE(
+ initial_work_area_bounds.ToString(),
+ ScreenAsh::GetMaximizedWindowBoundsInParent(window.get()).ToString());
}
// Tests normal->fullscreen->normal.
@@ -169,7 +170,7 @@ TEST_F(BaseLayoutManagerTest, BoundsWithScreenEdgeVisible) {
// It should have the default maximized window bounds, inset by the grid size.
int grid_size = ash::Shell::GetInstance()->GetGridSize();
gfx::Rect max_bounds =
- ash::ScreenAsh::GetMaximizedWindowParentBounds(window.get());
+ ash::ScreenAsh::GetMaximizedWindowBoundsInParent(window.get());
max_bounds.Inset(grid_size, grid_size);
EXPECT_EQ(max_bounds.ToString(), window->bounds().ToString());
}
« no previous file with comments | « ash/wm/base_layout_manager.cc ('k') | ash/wm/custom_frame_view_ash_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698