chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc - Issue 10795013: Rename bounds accessors to be intuitive and consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Issue 10795013: Rename bounds accessors to be intuitive and consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

index 4023f457ab2a2d6ed0d904daed0291ac03f5eff7..69be08cf1ac2a0374686052e23f9801c1b2a00d0 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

@@ -240,7 +240,7 @@ void OmniboxPopupContentsView::UpdatePopupAppearance() {

} else {

// Animate the popup shrinking, but don't animate growing larger since that

// would make the popup feel less responsive.

- start_bounds_ = GetWidget()->GetWindowScreenBounds();

+ start_bounds_ = GetWidget()->GetWindowBoundsInScreen();

if (target_bounds_.height() < start_bounds_.height())

size_animation_.Show();

else