Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1688)

Unified Diff: ash/wm/panel_layout_manager_unittest.cc

Issue 10795013: Rename bounds accessors to be intuitive and consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/panel_layout_manager.cc ('k') | ash/wm/shelf_layout_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/panel_layout_manager_unittest.cc
diff --git a/ash/wm/panel_layout_manager_unittest.cc b/ash/wm/panel_layout_manager_unittest.cc
index 7835575d68ab079853c1f1153fbe8ae2bf8547d2..1e1c7a002b41dc5f0871b66cb8642758338c8442 100644
--- a/ash/wm/panel_layout_manager_unittest.cc
+++ b/ash/wm/panel_layout_manager_unittest.cc
@@ -80,7 +80,7 @@ class PanelLayoutManagerTest : public ash::test::AshTestBase {
gfx::Rect icon_bounds = launcher->GetScreenBoundsOfItemIconForWindow(panel);
ASSERT_FALSE(icon_bounds.IsEmpty());
- gfx::Rect window_bounds = panel->GetRootWindowBounds();
+ gfx::Rect window_bounds = panel->GetBoundsInRootWindow();
// 1-pixel tolerance--since we center panels over their icons, panels with
// odd pixel widths won't be perfectly lined up with even pixel width
@@ -88,7 +88,7 @@ class PanelLayoutManagerTest : public ash::test::AshTestBase {
EXPECT_NEAR(icon_bounds.CenterPoint().x(),
window_bounds.CenterPoint().x(),
1);
- EXPECT_EQ(launcher->widget()->GetWindowScreenBounds().y(),
+ EXPECT_EQ(launcher->widget()->GetWindowBoundsInScreen().y(),
window_bounds.bottom());
}
@@ -98,10 +98,10 @@ class PanelLayoutManagerTest : public ash::test::AshTestBase {
views::Widget* widget = NULL;
GetCalloutWidget(&widget);
EXPECT_TRUE(widget->IsVisible());
- EXPECT_EQ(panel->GetRootWindowBounds().bottom(),
- widget->GetWindowScreenBounds().y());
- EXPECT_NEAR(panel->GetRootWindowBounds().CenterPoint().x(),
- widget->GetWindowScreenBounds().CenterPoint().x(),
+ EXPECT_EQ(panel->GetBoundsInRootWindow().bottom(),
+ widget->GetWindowBoundsInScreen().y());
+ EXPECT_NEAR(panel->GetBoundsInRootWindow().CenterPoint().x(),
+ widget->GetWindowBoundsInScreen().CenterPoint().x(),
1);
}
« no previous file with comments | « ash/wm/panel_layout_manager.cc ('k') | ash/wm/shelf_layout_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698