Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5500)

Unified Diff: chrome/browser/ui/views/web_dialog_view_browsertest.cc

Issue 10795013: Rename bounds accessors to be intuitive and consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/web_dialog_view_browsertest.cc
diff --git a/chrome/browser/ui/views/web_dialog_view_browsertest.cc b/chrome/browser/ui/views/web_dialog_view_browsertest.cc
index 11e3d42ade7bfb0680fe6e81c96dfb068464e598..3882ea148f2d39e8f4200caa6221ea8448db0b7b 100644
--- a/chrome/browser/ui/views/web_dialog_view_browsertest.cc
+++ b/chrome/browser/ui/views/web_dialog_view_browsertest.cc
@@ -109,7 +109,7 @@ IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) {
// TestWebDialogView should quit current message loop on size change.
view->set_should_quit_on_size_change(true);
- gfx::Rect bounds = view->GetWidget()->GetClientAreaScreenBounds();
+ gfx::Rect bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
gfx::Rect set_bounds = bounds;
gfx::Rect actual_bounds, rwhv_bounds;
@@ -120,7 +120,7 @@ IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) {
view->MoveContents(web_contents, set_bounds);
ui_test_utils::RunMessageLoop(); // TestWebDialogView will quit.
- actual_bounds = view->GetWidget()->GetClientAreaScreenBounds();
+ actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
EXPECT_EQ(set_bounds, actual_bounds);
rwhv_bounds =
@@ -136,7 +136,7 @@ IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) {
view->MoveContents(web_contents, set_bounds);
ui_test_utils::RunMessageLoop(); // TestWebDialogView will quit.
- actual_bounds = view->GetWidget()->GetClientAreaScreenBounds();
+ actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
EXPECT_EQ(set_bounds, actual_bounds);
rwhv_bounds =
@@ -152,7 +152,7 @@ IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) {
view->MoveContents(web_contents, set_bounds);
ui_test_utils::RunMessageLoop(); // TestWebDialogView will quit.
- actual_bounds = view->GetWidget()->GetClientAreaScreenBounds();
+ actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
EXPECT_EQ(set_bounds, actual_bounds);
rwhv_bounds =
@@ -168,7 +168,7 @@ IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) {
view->MoveContents(web_contents, set_bounds);
ui_test_utils::RunMessageLoop(); // TestWebDialogView will quit.
- actual_bounds = view->GetWidget()->GetClientAreaScreenBounds();
+ actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();
EXPECT_LT(0, actual_bounds.width());
EXPECT_LT(0, actual_bounds.height());
}
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | chrome/browser/ui/window_sizer/window_sizer_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698