chrome/browser/ui/views/tabs/tab_drag_controller.cc - Issue 10795013: Rename bounds accessors to be intuitive and consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 10795013: Rename bounds accessors to be intuitive and consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

index bafa1bfd59b7042431bc88b5de5da4d2b121c98e..0215b20f7371b23104f60ed786a33686206f9de5 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

@@ -1871,7 +1871,7 @@ Browser* TabDragController::CreateBrowserForDrag(

Browser* browser = Browser::Create(drag_data_[0].contents->profile());

gfx::Point center(0, source->height() / 2);

views::View::ConvertPointToWidget(source, &center);

- gfx::Rect new_bounds(source->GetWidget()->GetWindowScreenBounds());

+ gfx::Rect new_bounds(source->GetWidget()->GetWindowBoundsInScreen());

new_bounds.set_y(screen_point.y() - center.y());

switch (GetDetachPosition(screen_point)) {

case DETACH_BEFORE: