ui/views/controls/scrollbar/base_scroll_bar.cc - Issue 10795013: Rename bounds accessors to be intuitive and consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/scrollbar/base_scroll_bar.cc

Issue 10795013: Rename bounds accessors to be intuitive and consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/scrollbar/base_scroll_bar.cc

diff --git a/ui/views/controls/scrollbar/base_scroll_bar.cc b/ui/views/controls/scrollbar/base_scroll_bar.cc

index 58e21167d493942f2893651b7310ef1839d2f3ce..42b1b1df449644740ebcb052158175ba615eaea2 100644

--- a/ui/views/controls/scrollbar/base_scroll_bar.cc

+++ b/ui/views/controls/scrollbar/base_scroll_bar.cc

@@ -219,7 +219,7 @@ enum ScrollBarContextMenuCommands {

void BaseScrollBar::ShowContextMenuForView(View* source, const gfx::Point& p) {

Widget* widget = GetWidget();

- gfx::Rect widget_bounds = widget->GetWindowScreenBounds();

+ gfx::Rect widget_bounds = widget->GetWindowBoundsInScreen();

gfx::Point temp_pt(p.x() - widget_bounds.x(), p.y() - widget_bounds.y());

View::ConvertPointFromWidget(this, &temp_pt);

context_menu_mouse_position_ = IsHorizontal() ? temp_pt.x() : temp_pt.y();

« no previous file with comments | « ui/views/controls/button/menu_button.cc ('k') | ui/views/examples/widget_example.cc » ('j') | no next file with comments »