Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3369)

Unified Diff: chrome/browser/ui/panels/panel_view.cc

Issue 10795013: Rename bounds accessors to be intuitive and consistent (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/views/about_chrome_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_view.cc
diff --git a/chrome/browser/ui/panels/panel_view.cc b/chrome/browser/ui/panels/panel_view.cc
index d9e9160ccac9097472a034fd022e5348348e415f..3eea9747cf7da4c9bb8ad976f9b8a8561d78d1cd 100644
--- a/chrome/browser/ui/panels/panel_view.cc
+++ b/chrome/browser/ui/panels/panel_view.cc
@@ -191,7 +191,7 @@ void PanelView::SetBoundsInternal(const gfx::Rect& new_bounds, bool animate) {
return;
}
- animation_start_bounds_ = window_->GetWindowScreenBounds();
+ animation_start_bounds_ = window_->GetWindowBoundsInScreen();
bounds_animator_.reset(new PanelBoundsAnimation(
this, panel_.get(), animation_start_bounds_, new_bounds));
@@ -460,7 +460,7 @@ void PanelView::OnWindowEndUserBoundsChange() {
panel_->OnPanelEndUserResizing();
// No need to proceed with post-resizing update when there is no size change.
- gfx::Rect new_bounds = window_->GetWindowScreenBounds();
+ gfx::Rect new_bounds = window_->GetWindowBoundsInScreen();
if (bounds_ == new_bounds)
return;
bounds_ = new_bounds;
@@ -642,7 +642,7 @@ bool PanelView::IsAnimatingBounds() const {
}
bool PanelView::IsWithinResizingArea(const gfx::Point& mouse_location) const {
- gfx::Rect bounds = window_->GetWindowScreenBounds();
+ gfx::Rect bounds = window_->GetWindowBoundsInScreen();
DCHECK(bounds.Contains(mouse_location));
return mouse_location.x() < bounds.x() + kResizeInsideBoundsSize ||
mouse_location.x() >= bounds.right() - kResizeInsideBoundsSize ||
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/views/about_chrome_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698