Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed)

Created:
8 years, 5 months ago by Ben Goodger (Google)
Modified:
8 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, jeremya+watch_chromium.org, yoshiki+watch_chromium.org, rdsmith+dwatch_chromium.org, dcheng, rginda+watch_chromium.org, scheib+watch_chromium.org, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, ncarter (slow), ben+watch_chromium.org, aboxhall+watch_chromium.org, Ilya Sherman, achuith+watch_chromium.org, apatrick_chromium, marja+watch_chromium.org, Satish, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), dbeam+watch-ntp_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, dtseng+watch_chromium.org, kkania, Raghu Simha, cbentzel+watch_chromium.org, jianli, feature-media-reviews_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, mihaip-chromium-reviews_chromium.org, akalin, hashimoto+watch_chromium.org, tfarina, Dmitry Titov, davidbarr+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, eroman, robertshield, jshin+watch_chromium.org, dyu1, estade+watch_chromium.org, James Su, mmenke, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move tab functions off Browser into browser_tabstrip and browser_tabrestore. http://crbug.com/133576 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145015

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2220 lines, -1814 lines) Patch
M chrome/browser/accessibility/accessibility_extension_apitest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 3 4 5 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/autofill/autofill_popup_view_browsertest.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/autofill/form_structure_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_misc_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 31 chunks +36 lines, -38 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 2 3 4 5 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/browser_commands_unittest.cc View 1 2 3 4 5 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/browser_encoding_browsertest.cc View 1 2 3 4 5 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 2 3 4 5 19 chunks +34 lines, -31 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 2 3 4 5 11 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 2 3 4 5 37 chunks +71 lines, -68 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chrome_main_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_switches_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/enrollment_dialog_view.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler_api.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_handler_util.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/drive_task_executor.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/media/media_player.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/oom_priority_manager_browsertest.cc View 1 2 3 4 5 4 chunks +18 lines, -16 lines 0 comments Download
M chrome/browser/collected_cookies_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 2 3 4 5 7 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/crash_recovery_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 3 4 5 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 3 4 5 13 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/download/download_danger_prompt_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 2 3 4 5 5 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_action_apitest.cc View 1 2 3 4 5 7 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc View 1 2 3 4 5 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/script_badge_apitest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.cc View 1 2 3 4 5 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 2 3 4 5 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 2 3 4 5 20 chunks +49 lines, -47 lines 0 comments Download
M chrome/browser/extensions/browser_action_apitest.cc View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/browser_extension_window_controller.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_app_api_browsertest.cc View 1 2 3 4 5 9 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 2 3 4 5 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_browsertests.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_dom_clipboard_apitest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_source_apitest.cc View 1 2 3 4 5 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_browsertest.cc View 1 2 3 4 5 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_resource_request_policy_apitest.cc View 1 2 3 4 5 11 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_url_rewrite_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 1 2 3 4 5 5 chunks +22 lines, -21 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/options_page_apitest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/page_action_browsertest.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/process_management_browsertest.cc View 1 2 3 4 5 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/extensions/subscribe_page_action_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/web_contents_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_install_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/external_extension_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 2 3 4 5 14 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/history/multipart_browsertest.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 1 2 3 4 5 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/iframe_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/importer/importer_host.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/infobars/infobars_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 2 3 4 5 7 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/loadtimes_extension_bindings_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/net/load_timing_observer_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/page_cycler/page_cycler.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/page_cycler/page_cycler_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/popup_blocker_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prefetch_browsertest.cc View 1 2 3 4 5 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 3 4 5 11 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/web_cache_manager_browsertest.cc View 1 2 3 4 5 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/repost_form_warning_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 2 3 4 5 18 chunks +23 lines, -22 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 3 4 5 13 chunks +32 lines, -30 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 2 3 4 5 17 chunks +39 lines, -34 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_browsertest.cc View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 4 5 44 chunks +51 lines, -50 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/sessions_sync_perf_test.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 2 3 4 5 9 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/view_source_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_restore_browsertest.cc View 1 2 3 4 5 15 chunks +21 lines, -19 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 5 2 chunks +0 lines, -82 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 50 chunks +72 lines, -290 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 5 28 chunks +41 lines, -40 lines 0 comments Download
M chrome/browser/ui/browser_close_browsertest.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 4 5 26 chunks +36 lines, -33 lines 0 comments Download
M chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 3 4 5 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 3 4 5 40 chunks +73 lines, -66 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest_chromeos.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 1 2 3 4 5 4 chunks +12 lines, -9 lines 0 comments Download
A chrome/browser/ui/browser_tabrestore.h View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/ui/browser_tabrestore.cc View 1 chunk +117 lines, -0 lines 0 comments Download
A chrome/browser/ui/browser_tabstrip.h View 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/browser/ui/browser_tabstrip.cc View 1 chunk +153 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_toolbar_model_delegate.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_win.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 1 2 3 4 5 6 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 4 5 18 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/cocoa_profile_test.mm View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/keystone_infobar_delegate.mm View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window_unittest.mm View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 2 3 4 5 3 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 2 3 4 5 32 chunks +38 lines, -38 lines 0 comments Download
A + chrome/browser/ui/fullscreen_controller.cc View 1 2 3 4 5 chunks +5 lines, -4 lines 0 comments Download
A + chrome/browser/ui/fullscreen_controller_browsertest.cc View 1 2 3 4 4 chunks +6 lines, -5 lines 0 comments Download
A + chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
A + chrome/browser/ui/fullscreen_controller_test.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 3 4 5 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 1 2 3 4 5 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 2 3 4 5 18 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 3 4 5 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/old_panel.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/old_panel_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 2 3 4 5 10 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/ui/search/search_delegate_unittest.cc View 1 2 3 4 5 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/singleton_tabs.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/autolaunch_prompt_win.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/bad_flags_prompt.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/obsolete_os_prompt_gtk.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/obsolete_os_prompt_mac.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/session_crashed_prompt.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 2 3 4 5 9 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 4 5 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegate.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc View 1 2 3 4 5 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_service_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.h View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 2 3 4 5 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_order_controller.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 2 3 4 5 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/app_list/extension_app_item.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/app_list/search_builder.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/panel_view_aura.cc View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/ash/user_action_handler.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 2 3 4 5 8 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 1 2 3 4 5 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/web_dialog_view_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 1 2 3 4 5 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 1 2 3 4 5 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_combiner.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 1 2 3 4 5 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/unload_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 3 4 5 7 chunks +12 lines, -9 lines 0 comments Download
M chrome/test/data/webui/certificate_viewer_ui_test-inl.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/perf/rendering/latency_tests.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/perf/rendering/throughput_tests.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 2 3 4 5 6 chunks +6 lines, -5 lines 0 comments Download
M content/browser/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/cross_platform_accessibility_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/renderer_accessibility_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/device_orientation/device_orientation_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/save_package_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/media_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/mouseleave_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/plugin_browsertest.cc View 1 2 3 4 5 5 chunks +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 2 3 4 5 7 chunks +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 2 3 4 5 4 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 2 3 4 5 39 chunks +94 lines, -92 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_browsertest.cc View 1 2 3 4 5 8 chunks +8 lines, -7 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 1 2 3 4 5 6 chunks +8 lines, -7 lines 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/webkit_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/worker_host/test/worker_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/test/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/test/layout_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
8 years, 5 months ago (2012-06-28 21:50:19 UTC) #1
sky
LGTM
8 years, 5 months ago (2012-06-28 22:00:34 UTC) #2
tfarina
8 years, 5 months ago (2012-06-29 00:42:53 UTC) #3 
Ben, do you mind naming them browser_tab_strip and browser_tab_restore?

This is consistent with for example  chrome/browser/ui/tabs/tab_strip_model.h

I found weird to read tabstrip altogether instead of separated. tab_strip seems
more readable.

Powered by Google App Engine
This is Rietveld 408576698