Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/ui/panels/old_panel_browsertest.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/panels/old_panel.cc ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/utf_string_conversions.h" 6 #include "base/utf_string_conversions.h"
7 #include "chrome/browser/download/download_service.h" 7 #include "chrome/browser/download/download_service.h"
8 #include "chrome/browser/download/download_service_factory.h" 8 #include "chrome/browser/download/download_service_factory.h"
9 #include "chrome/browser/net/url_request_mock_util.h" 9 #include "chrome/browser/net/url_request_mock_util.h"
10 #include "chrome/browser/prefs/browser_prefs.h" 10 #include "chrome/browser/prefs/browser_prefs.h"
11 #include "chrome/browser/prefs/pref_service.h" 11 #include "chrome/browser/prefs/pref_service.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h" 13 #include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h"
14 #include "chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h" 14 #include "chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h"
15 #include "chrome/browser/ui/browser_commands.h" 15 #include "chrome/browser/ui/browser_commands.h"
16 #include "chrome/browser/ui/browser_finder.h" 16 #include "chrome/browser/ui/browser_finder.h"
17 #include "chrome/browser/ui/browser_list.h" 17 #include "chrome/browser/ui/browser_list.h"
18 #include "chrome/browser/ui/browser_tabstrip.h"
18 #include "chrome/browser/ui/browser_window.h" 19 #include "chrome/browser/ui/browser_window.h"
19 #include "chrome/browser/ui/find_bar/find_bar.h" 20 #include "chrome/browser/ui/find_bar/find_bar.h"
20 #include "chrome/browser/ui/find_bar/find_bar_controller.h" 21 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
21 #include "chrome/browser/ui/panels/old_base_panel_browser_test.h" 22 #include "chrome/browser/ui/panels/old_base_panel_browser_test.h"
22 #include "chrome/browser/ui/panels/docked_panel_strip.h" 23 #include "chrome/browser/ui/panels/docked_panel_strip.h"
23 #include "chrome/browser/ui/panels/native_panel.h" 24 #include "chrome/browser/ui/panels/native_panel.h"
24 #include "chrome/browser/ui/panels/panel.h" 25 #include "chrome/browser/ui/panels/panel.h"
25 #include "chrome/browser/ui/panels/panel_manager.h" 26 #include "chrome/browser/ui/panels/panel_manager.h"
26 #include "chrome/browser/ui/panels/test_panel_mouse_watcher.h" 27 #include "chrome/browser/ui/panels/test_panel_mouse_watcher.h"
27 #include "chrome/browser/ui/tabs/tab_strip_model.h" 28 #include "chrome/browser/ui/tabs/tab_strip_model.h"
(...skipping 1398 matching lines...) Expand 10 before | Expand all | Expand 10 after
1426 CreatePanelParams params("PanelTest1", gfx::Rect(), SHOW_AS_ACTIVE); 1427 CreatePanelParams params("PanelTest1", gfx::Rect(), SHOW_AS_ACTIVE);
1427 Panel* panel = CreatePanelWithParams(params); 1428 Panel* panel = CreatePanelWithParams(params);
1428 Browser* panel_browser = panel->browser(); 1429 Browser* panel_browser = panel->browser();
1429 EXPECT_EQ(2U, BrowserList::size()); 1430 EXPECT_EQ(2U, BrowserList::size());
1430 1431
1431 // Swap tab contents over to the panel from the tabbed browser. 1432 // Swap tab contents over to the panel from the tabbed browser.
1432 TabContents* contents = browser()->tab_strip_model()->DetachTabContentsAt(0); 1433 TabContents* contents = browser()->tab_strip_model()->DetachTabContentsAt(0);
1433 panel_browser->tab_strip_model()->InsertTabContentsAt( 1434 panel_browser->tab_strip_model()->InsertTabContentsAt(
1434 0, contents, TabStripModel::ADD_NONE); 1435 0, contents, TabStripModel::ADD_NONE);
1435 chrome::SelectNumberedTab(panel_browser, 0); 1436 chrome::SelectNumberedTab(panel_browser, 0);
1436 EXPECT_EQ(contents, panel_browser->GetActiveTabContents()); 1437 EXPECT_EQ(contents, chrome::GetActiveTabContents(panel_browser));
1437 EXPECT_EQ(1, PanelManager::GetInstance()->num_panels()); 1438 EXPECT_EQ(1, PanelManager::GetInstance()->num_panels());
1438 1439
1439 // Ensure that the tab contents were noticed by the panel by 1440 // Ensure that the tab contents were noticed by the panel by
1440 // verifying that the panel auto resizes correctly. (Panel 1441 // verifying that the panel auto resizes correctly. (Panel
1441 // enables auto resizing when tab contents are detected.) 1442 // enables auto resizing when tab contents are detected.)
1442 int initial_width = panel->GetBounds().width(); 1443 int initial_width = panel->GetBounds().width();
1443 ui_test_utils::WindowedNotificationObserver enlarge( 1444 ui_test_utils::WindowedNotificationObserver enlarge(
1444 chrome::NOTIFICATION_PANEL_BOUNDS_ANIMATIONS_FINISHED, 1445 chrome::NOTIFICATION_PANEL_BOUNDS_ANIMATIONS_FINISHED,
1445 content::Source<Panel>(panel)); 1446 content::Source<Panel>(panel));
1446 EXPECT_TRUE(ui_test_utils::ExecuteJavaScript( 1447 EXPECT_TRUE(ui_test_utils::ExecuteJavaScript(
1447 panel_browser->GetActiveWebContents()->GetRenderViewHost(), 1448 chrome::GetActiveWebContents(panel_browser)->GetRenderViewHost(),
1448 std::wstring(), 1449 std::wstring(),
1449 L"changeSize(50);")); 1450 L"changeSize(50);"));
1450 enlarge.Wait(); 1451 enlarge.Wait();
1451 EXPECT_GT(panel->GetBounds().width(), initial_width); 1452 EXPECT_GT(panel->GetBounds().width(), initial_width);
1452 1453
1453 // Swapping tab contents back to the browser should close the panel. 1454 // Swapping tab contents back to the browser should close the panel.
1454 ui_test_utils::WindowedNotificationObserver signal( 1455 ui_test_utils::WindowedNotificationObserver signal(
1455 chrome::NOTIFICATION_PANEL_CLOSED, 1456 chrome::NOTIFICATION_PANEL_CLOSED,
1456 content::Source<Panel>(panel)); 1457 content::Source<Panel>(panel));
1457 chrome::ConvertPopupToTabbedBrowser(panel_browser); 1458 chrome::ConvertPopupToTabbedBrowser(panel_browser);
1458 signal.Wait(); 1459 signal.Wait();
1459 EXPECT_EQ(0, PanelManager::GetInstance()->num_panels()); 1460 EXPECT_EQ(0, PanelManager::GetInstance()->num_panels());
1460 1461
1461 Browser* tabbed_browser = browser::FindTabbedBrowser(profile, false); 1462 Browser* tabbed_browser = browser::FindTabbedBrowser(profile, false);
1462 EXPECT_EQ(contents, tabbed_browser->GetActiveTabContents()); 1463 EXPECT_EQ(contents, chrome::GetActiveTabContents(tabbed_browser));
1463 tabbed_browser->window()->Close(); 1464 tabbed_browser->window()->Close();
1464 } 1465 }
1465 1466
1466 IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, SizeClamping) { 1467 IN_PROC_BROWSER_TEST_F(OldPanelBrowserTest, SizeClamping) {
1467 // Using '0' sizes is equivalent of not providing sizes in API and causes 1468 // Using '0' sizes is equivalent of not providing sizes in API and causes
1468 // minimum sizes to be applied to facilitate auto-sizing. 1469 // minimum sizes to be applied to facilitate auto-sizing.
1469 CreatePanelParams params("Panel", gfx::Rect(), SHOW_AS_ACTIVE); 1470 CreatePanelParams params("Panel", gfx::Rect(), SHOW_AS_ACTIVE);
1470 Panel* panel = CreatePanelWithParams(params); 1471 Panel* panel = CreatePanelWithParams(params);
1471 EXPECT_EQ(panel->min_size().width(), panel->GetBounds().width()); 1472 EXPECT_EQ(panel->min_size().width(), panel->GetBounds().width());
1472 EXPECT_EQ(panel->min_size().height(), panel->GetBounds().height()); 1473 EXPECT_EQ(panel->min_size().height(), panel->GetBounds().height());
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
1750 Browser* tabbed_browser = browser::FindTabbedBrowser(profile, false); 1751 Browser* tabbed_browser = browser::FindTabbedBrowser(profile, false);
1751 EXPECT_EQ(1, tabbed_browser->tab_count()); 1752 EXPECT_EQ(1, tabbed_browser->tab_count());
1752 ASSERT_TRUE(tabbed_browser->window()->IsDownloadShelfVisible()); 1753 ASSERT_TRUE(tabbed_browser->window()->IsDownloadShelfVisible());
1753 chrome::CloseWindow(tabbed_browser); 1754 chrome::CloseWindow(tabbed_browser);
1754 1755
1755 EXPECT_EQ(1, panel_browser->tab_count()); 1756 EXPECT_EQ(1, panel_browser->tab_count());
1756 ASSERT_FALSE(panel_browser->window()->IsDownloadShelfVisible()); 1757 ASSERT_FALSE(panel_browser->window()->IsDownloadShelfVisible());
1757 1758
1758 chrome::CloseWindow(panel_browser); 1759 chrome::CloseWindow(panel_browser);
1759 } 1760 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/old_panel.cc ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698