chrome/browser/automation/automation_util.cc - Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_util.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/automation_tab_helper_browsertest.cc ('k') | chrome/browser/automation/testing_automation_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/automation_util.cc

===================================================================

--- chrome/browser/automation/automation_util.cc (revision 145001)

+++ chrome/browser/automation/automation_util.cc (working copy)

@@ -24,6 +24,7 @@

#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/tab_contents/tab_contents.h"

#include "chrome/browser/view_type_utils.h"

#include "chrome/common/automation_id.h"

@@ -145,7 +146,7 @@

Browser* browser = GetBrowserAt(browser_index);

if (!browser || tab_index >= browser->tab_count())

return NULL;

- return browser->GetWebContentsAt(tab_index);

+ return chrome::GetWebContentsAt(browser, tab_index);

}

Browser* GetBrowserForTab(WebContents* tab) {

@@ -153,7 +154,7 @@

for (; browser_iter != BrowserList::end(); ++browser_iter) {

Browser* browser = *browser_iter;

for (int tab_index = 0; tab_index < browser->tab_count(); ++tab_index) {

- if (browser->GetWebContentsAt(tab_index) == tab)

+ if (chrome::GetWebContentsAt(browser, tab_index) == tab)

return browser;

}

@@ -452,7 +453,7 @@

for (; iter != BrowserList::end(); ++iter) {

Browser* browser = *iter;

for (int tab_index = 0; tab_index < browser->tab_count(); ++tab_index) {

- TabContents* tab_contents = browser->GetTabContentsAt(tab_index);

+ TabContents* tab_contents = chrome::GetTabContentsAt(browser, tab_index);

if (base::IntToString(

tab_contents->restore_tab_helper()->session_id().id()) ==

id.id()) {