Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Unified Diff: chrome/browser/sync/test/integration/sync_test.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_test.cc
===================================================================
--- chrome/browser/sync/test/integration/sync_test.cc (revision 145001)
+++ chrome/browser/sync/test/integration/sync_test.cc (working copy)
@@ -30,6 +30,7 @@
#include "chrome/browser/sync/test/integration/sync_datatype_helper.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/net/gaia/gaia_urls.h"
@@ -617,7 +618,7 @@
std::string path = "chromiumsync/disablenotifications";
ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
ASSERT_EQ("Notifications disabled",
- UTF16ToASCII(browser()->GetActiveWebContents()->GetTitle()));
+ UTF16ToASCII(chrome::GetActiveWebContents(browser())->GetTitle()));
}
void SyncTest::DisableNotifications() {
@@ -630,7 +631,7 @@
std::string path = "chromiumsync/enablenotifications";
ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
ASSERT_EQ("Notifications enabled",
- UTF16ToASCII(browser()->GetActiveWebContents()->GetTitle()));
+ UTF16ToASCII(chrome::GetActiveWebContents(browser())->GetTitle()));
}
void SyncTest::EnableNotifications() {
@@ -650,7 +651,7 @@
syncer::kSyncP2PNotificationChannel + "&data=" + data;
ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
ASSERT_EQ("Notification sent",
- UTF16ToASCII(browser()->GetActiveWebContents()->GetTitle()));
+ UTF16ToASCII(chrome::GetActiveWebContents(browser())->GetTitle()));
}
bool SyncTest::ServerSupportsErrorTriggering() const {
@@ -675,7 +676,7 @@
}
ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
ASSERT_EQ("Migration: 200",
- UTF16ToASCII(browser()->GetActiveWebContents()->GetTitle()));
+ UTF16ToASCII(chrome::GetActiveWebContents(browser())->GetTitle()));
}
void SyncTest::TriggerBirthdayError() {
@@ -683,7 +684,7 @@
std::string path = "chromiumsync/birthdayerror";
ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
ASSERT_EQ("Birthday error",
- UTF16ToASCII(browser()->GetActiveWebContents()->GetTitle()));
+ UTF16ToASCII(chrome::GetActiveWebContents(browser())->GetTitle()));
}
void SyncTest::TriggerTransientError() {
@@ -691,7 +692,7 @@
std::string path = "chromiumsync/transienterror";
ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
ASSERT_EQ("Transient error",
- UTF16ToASCII(browser()->GetActiveWebContents()->GetTitle()));
+ UTF16ToASCII(chrome::GetActiveWebContents(browser())->GetTitle()));
}
void SyncTest::TriggerAuthError() {
@@ -769,7 +770,7 @@
ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
std::string output = UTF16ToASCII(
- browser()->GetActiveWebContents()->GetTitle());
+ chrome::GetActiveWebContents(browser())->GetTitle());
ASSERT_TRUE(output.find("SetError: 200") != string16::npos);
}
@@ -778,7 +779,7 @@
std::string path = "chromiumsync/createsyncedbookmarks";
ui_test_utils::NavigateToURL(browser(), sync_server_.GetURL(path));
ASSERT_EQ("Synced Bookmarks",
- UTF16ToASCII(browser()->GetActiveWebContents()->GetTitle()));
+ UTF16ToASCII(chrome::GetActiveWebContents(browser())->GetTitle()));
}
int SyncTest::NumberOfDefaultSyncItems() const {

Powered by Google App Engine
This is Rietveld 408576698