chrome/browser/background/background_contents_service.cc - Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/bookmarks/bookmark_context_menu_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_contents_service.cc

===================================================================

--- chrome/browser/background/background_contents_service.cc (revision 145001)

+++ chrome/browser/background/background_contents_service.cc (working copy)

@@ -23,6 +23,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

+#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension.h"

@@ -613,7 +614,8 @@

bool user_gesture) {

Browser* browser = browser::FindLastActiveWithProfile(

Profile::FromBrowserContext(new_contents->GetBrowserContext()));

- if (!browser)

- return;

- browser->AddWebContents(new_contents, disposition, initial_pos, user_gesture);

+ if (browser) {

+ chrome::AddWebContents(browser, NULL, new_contents, disposition,

+ initial_pos, user_gesture);

+ }

}