chrome/browser/errorpage_browsertest.cc - Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/errorpage_browsertest.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/errorpage_browsertest.cc

===================================================================

--- chrome/browser/errorpage_browsertest.cc (revision 145001)

+++ chrome/browser/errorpage_browsertest.cc (working copy)

@@ -7,6 +7,7 @@

#include "chrome/browser/net/url_request_mock_util.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

+#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/tab_contents/tab_contents.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/ui_test_utils.h"

@@ -39,7 +40,7 @@

const std::string& expected_title,

int num_navigations) {

ui_test_utils::TitleWatcher title_watcher(

- browser()->GetActiveWebContents(),

+ chrome::GetActiveWebContents(browser()),

ASCIIToUTF16(expected_title));

ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(

@@ -85,12 +86,12 @@

int num_navigations,

HistoryNavigationDirection direction) {

ui_test_utils::TitleWatcher title_watcher(

- browser()->GetActiveWebContents(),

+ chrome::GetActiveWebContents(browser()),

ASCIIToUTF16(expected_title));

content::TestNavigationObserver test_navigation_observer(

content::Source<NavigationController>(

- &browser()->GetActiveWebContents()->GetController()),

+ &chrome::GetActiveWebContents(browser())->GetController()),

NULL,

num_navigations);

if (direction == HISTORY_NAVIGATE_BACK) {