chrome/browser/extensions/browser_action_apitest.cc - Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_action_apitest.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/app_process_apitest.cc ('k') | chrome/browser/extensions/browser_extension_window_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/browser_action_apitest.cc

===================================================================

--- chrome/browser/extensions/browser_action_apitest.cc (revision 145001)

+++ chrome/browser/extensions/browser_action_apitest.cc (working copy)

@@ -2,6 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "chrome/browser/ui/browser_tabstrip.h"

// Tests that tooltips of a browser action icon can be specified using UTF8.

// See http://crbug.com/25349.

IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, TitleLocalizationBrowserAction) {

@@ -18,7 +20,8 @@

extension->description().c_str());

EXPECT_STREQ(WideToUTF8(L"Hreggvi\u00F0ur is my name").c_str(),

extension->name().c_str());

- int tab_id = ExtensionTabUtil::GetTabId(browser()->GetActiveWebContents());

+ int tab_id = ExtensionTabUtil::GetTabId(

+ chrome::GetActiveWebContents(browser()));

EXPECT_STREQ(WideToUTF8(L"Hreggvi\u00F0ur").c_str(),

extension->browser_action()->GetTitle(tab_id).c_str());

}