content/browser/dom_storage/dom_storage_browsertest.cc - Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/dom_storage/dom_storage_browsertest.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_orientation/device_orientation_browsertest.cc ('k') | content/browser/download/mhtml_generation_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/dom_storage/dom_storage_browsertest.cc

===================================================================

--- content/browser/dom_storage/dom_storage_browsertest.cc (revision 145001)

+++ content/browser/dom_storage/dom_storage_browsertest.cc (working copy)

@@ -4,6 +4,7 @@

#include "base/path_service.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/browser/web_contents/web_contents_impl.h"

@@ -33,11 +34,12 @@

Browser* the_browser = incognito ? CreateIncognitoBrowser() : browser();

ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(

the_browser, test_url, 2);

- std::string result = the_browser->GetActiveWebContents()->GetURL().ref();

+ std::string result =

+ chrome::GetActiveWebContents(the_browser)->GetURL().ref();

if (result != "pass") {

std::string js_result;

ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractString(

- the_browser->GetActiveWebContents()->GetRenderViewHost(), L"",

+ chrome::GetActiveWebContents(the_browser)->GetRenderViewHost(), L"",

L"window.domAutomationController.send(getLog())", &js_result));

FAIL() << "Failed: " << js_result;

}