chrome/browser/ui/webui/feedback_ui.cc - Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/feedback_ui.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc ('k') | chrome/browser/ui/webui/inspect_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/feedback_ui.cc

===================================================================

--- chrome/browser/ui/webui/feedback_ui.cc (revision 145001)

+++ chrome/browser/ui/webui/feedback_ui.cc (working copy)

@@ -22,6 +22,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

+#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/singleton_tabs.h"

#include "chrome/browser/ui/tab_contents/tab_contents.h"

@@ -115,7 +116,7 @@

int GetIndexOfFeedbackTab(Browser* browser) {

GURL feedback_url(chrome::kChromeUIFeedbackURL);

for (int i = 0; i < browser->tab_count(); ++i) {

- WebContents* tab = browser->GetWebContentsAt(i);

+ WebContents* tab = chrome::GetWebContentsAt(browser, i);

if (tab && tab->GetURL().GetWithEmptyPath() == feedback_url)

return i;

}

@@ -145,7 +146,7 @@

int feedback_tab_index = GetIndexOfFeedbackTab(browser);

if (feedback_tab_index >= 0) {

// Do not refresh screenshot, do not create a new tab

- browser->ActivateTabAt(feedback_tab_index, true);

+ chrome::ActivateTabAt(browser, feedback_tab_index, true);

return;

}

@@ -385,7 +386,7 @@

if (!browser || index >= browser->tab_count())

return false;

- WebContents* target_tab = browser->GetWebContentsAt(index);

+ WebContents* target_tab = chrome::GetWebContentsAt(browser, index);

if (target_tab) {

target_tab_url_ = target_tab->GetURL().spec();

}