Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/file_path.h" 6 #include "base/file_path.h"
7 #include "base/synchronization/waitable_event.h" 7 #include "base/synchronization/waitable_event.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h" 9 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_tabstrip.h"
11 #include "chrome/browser/ui/views/ssl_client_certificate_selector.h" 12 #include "chrome/browser/ui/views/ssl_client_certificate_selector.h"
12 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
13 #include "chrome/test/base/ui_test_utils.h" 14 #include "chrome/test/base/ui_test_utils.h"
14 #include "content/public/browser/web_contents.h" 15 #include "content/public/browser/web_contents.h"
15 #include "net/base/cert_test_util.h" 16 #include "net/base/cert_test_util.h"
16 #include "net/base/ssl_cert_request_info.h" 17 #include "net/base/ssl_cert_request_info.h"
17 #include "net/base/x509_certificate.h" 18 #include "net/base/x509_certificate.h"
18 #include "net/http/http_transaction_factory.h" 19 #include "net/http/http_transaction_factory.h"
19 #include "net/url_request/url_request.h" 20 #include "net/url_request/url_request.h"
20 #include "net/url_request/url_request_context.h" 21 #include "net/url_request/url_request_context.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 54
54 virtual void SetUpOnMainThread() { 55 virtual void SetUpOnMainThread() {
55 url_request_context_getter_ = browser()->profile()->GetRequestContext(); 56 url_request_context_getter_ = browser()->profile()->GetRequestContext();
56 57
57 BrowserThread::PostTask( 58 BrowserThread::PostTask(
58 BrowserThread::IO, FROM_HERE, 59 BrowserThread::IO, FROM_HERE,
59 base::Bind(&SSLClientCertificateSelectorTest::SetUpOnIOThread, this)); 60 base::Bind(&SSLClientCertificateSelectorTest::SetUpOnIOThread, this));
60 61
61 io_loop_finished_event_.Wait(); 62 io_loop_finished_event_.Wait();
62 63
63 ui_test_utils::WaitForLoadStop(browser()->GetActiveWebContents()); 64 ui_test_utils::WaitForLoadStop(chrome::GetActiveWebContents(browser()));
64 selector_ = new SSLClientCertificateSelector( 65 selector_ = new SSLClientCertificateSelector(
65 browser()->GetActiveTabContents(), 66 chrome::GetActiveTabContents(browser()),
66 auth_requestor_->http_network_session_, 67 auth_requestor_->http_network_session_,
67 auth_requestor_->cert_request_info_, 68 auth_requestor_->cert_request_info_,
68 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected, 69 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
69 auth_requestor_)); 70 auth_requestor_));
70 selector_->Init(); 71 selector_->Init();
71 72
72 EXPECT_EQ(mit_davidben_cert_.get(), selector_->GetSelectedCert()); 73 EXPECT_EQ(mit_davidben_cert_.get(), selector_->GetSelectedCert());
73 } 74 }
74 75
75 virtual void SetUpOnIOThread() { 76 virtual void SetUpOnIOThread() {
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 cert_request_info_2_->client_certs.push_back(mit_davidben_cert_); 140 cert_request_info_2_->client_certs.push_back(mit_davidben_cert_);
140 cert_request_info_2_->client_certs.push_back(foaf_me_chromium_test_cert_); 141 cert_request_info_2_->client_certs.push_back(foaf_me_chromium_test_cert_);
141 } 142 }
142 143
143 virtual void SetUpOnMainThread() { 144 virtual void SetUpOnMainThread() {
144 // Also calls SetUpOnIOThread. 145 // Also calls SetUpOnIOThread.
145 SSLClientCertificateSelectorTest::SetUpOnMainThread(); 146 SSLClientCertificateSelectorTest::SetUpOnMainThread();
146 147
147 AddTabAtIndex(1, GURL("about:blank"), content::PAGE_TRANSITION_LINK); 148 AddTabAtIndex(1, GURL("about:blank"), content::PAGE_TRANSITION_LINK);
148 AddTabAtIndex(2, GURL("about:blank"), content::PAGE_TRANSITION_LINK); 149 AddTabAtIndex(2, GURL("about:blank"), content::PAGE_TRANSITION_LINK);
149 ASSERT_TRUE(NULL != browser()->GetWebContentsAt(0)); 150 ASSERT_TRUE(NULL != chrome::GetWebContentsAt(browser(), 0));
150 ASSERT_TRUE(NULL != browser()->GetWebContentsAt(1)); 151 ASSERT_TRUE(NULL != chrome::GetWebContentsAt(browser(), 1));
151 ASSERT_TRUE(NULL != browser()->GetWebContentsAt(2)); 152 ASSERT_TRUE(NULL != chrome::GetWebContentsAt(browser(), 2));
152 ui_test_utils::WaitForLoadStop(browser()->GetWebContentsAt(1)); 153 ui_test_utils::WaitForLoadStop(chrome::GetWebContentsAt(browser(), 1));
153 ui_test_utils::WaitForLoadStop(browser()->GetWebContentsAt(2)); 154 ui_test_utils::WaitForLoadStop(chrome::GetWebContentsAt(browser(), 2));
154 155
155 selector_1_ = new SSLClientCertificateSelector( 156 selector_1_ = new SSLClientCertificateSelector(
156 browser()->GetTabContentsAt(1), 157 chrome::GetTabContentsAt(browser(), 1),
157 auth_requestor_1_->http_network_session_, 158 auth_requestor_1_->http_network_session_,
158 auth_requestor_1_->cert_request_info_, 159 auth_requestor_1_->cert_request_info_,
159 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected, 160 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
160 auth_requestor_1_)); 161 auth_requestor_1_));
161 selector_1_->Init(); 162 selector_1_->Init();
162 selector_2_ = new SSLClientCertificateSelector( 163 selector_2_ = new SSLClientCertificateSelector(
163 browser()->GetTabContentsAt(2), 164 chrome::GetTabContentsAt(browser(), 2),
164 auth_requestor_2_->http_network_session_, 165 auth_requestor_2_->http_network_session_,
165 auth_requestor_2_->cert_request_info_, 166 auth_requestor_2_->cert_request_info_,
166 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected, 167 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
167 auth_requestor_2_)); 168 auth_requestor_2_));
168 selector_2_->Init(); 169 selector_2_->Init();
169 170
170 EXPECT_EQ(2, browser()->active_index()); 171 EXPECT_EQ(2, browser()->active_index());
171 EXPECT_EQ(mit_davidben_cert_.get(), selector_1_->GetSelectedCert()); 172 EXPECT_EQ(mit_davidben_cert_.get(), selector_1_->GetSelectedCert());
172 EXPECT_EQ(mit_davidben_cert_.get(), selector_2_->GetSelectedCert()); 173 EXPECT_EQ(mit_davidben_cert_.get(), selector_2_->GetSelectedCert());
173 } 174 }
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 } 223 }
223 224
224 virtual void SetUpOnMainThread() { 225 virtual void SetUpOnMainThread() {
225 browser_1_ = CreateIncognitoBrowser(); 226 browser_1_ = CreateIncognitoBrowser();
226 url_request_context_getter_1_ = browser_1_->profile()->GetRequestContext(); 227 url_request_context_getter_1_ = browser_1_->profile()->GetRequestContext();
227 228
228 // Also calls SetUpOnIOThread. 229 // Also calls SetUpOnIOThread.
229 SSLClientCertificateSelectorTest::SetUpOnMainThread(); 230 SSLClientCertificateSelectorTest::SetUpOnMainThread();
230 231
231 selector_1_ = new SSLClientCertificateSelector( 232 selector_1_ = new SSLClientCertificateSelector(
232 browser_1_->GetActiveTabContents(), 233 chrome::GetActiveTabContents(browser_1_),
233 auth_requestor_1_->http_network_session_, 234 auth_requestor_1_->http_network_session_,
234 auth_requestor_1_->cert_request_info_, 235 auth_requestor_1_->cert_request_info_,
235 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected, 236 base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
236 auth_requestor_1_)); 237 auth_requestor_1_));
237 selector_1_->Init(); 238 selector_1_->Init();
238 239
239 EXPECT_EQ(mit_davidben_cert_.get(), selector_1_->GetSelectedCert()); 240 EXPECT_EQ(mit_davidben_cert_.get(), selector_1_->GetSelectedCert());
240 } 241 }
241 242
242 virtual void SetUpOnIOThread() { 243 virtual void SetUpOnIOThread() {
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 EXPECT_TRUE(ui_test_utils::SendKeyPressSync( 367 EXPECT_TRUE(ui_test_utils::SendKeyPressSync(
367 browser_1_, ui::VKEY_RETURN, false, false, false, false)); 368 browser_1_, ui::VKEY_RETURN, false, false, false, false));
368 369
369 Mock::VerifyAndClear(auth_requestor_.get()); 370 Mock::VerifyAndClear(auth_requestor_.get());
370 Mock::VerifyAndClear(auth_requestor_1_.get()); 371 Mock::VerifyAndClear(auth_requestor_1_.get());
371 372
372 // Now let the default selection for auth_requestor_ mock get checked on 373 // Now let the default selection for auth_requestor_ mock get checked on
373 // destruction. 374 // destruction.
374 EXPECT_CALL(*auth_requestor_, CertificateSelected(NULL)); 375 EXPECT_CALL(*auth_requestor_, CertificateSelected(NULL));
375 } 376 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698