chrome/browser/ui/intents/web_intent_picker_controller.cc - Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc ('k') | chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/intents/web_intent_picker_controller.cc

===================================================================

--- chrome/browser/ui/intents/web_intent_picker_controller.cc (revision 145001)

+++ chrome/browser/ui/intents/web_intent_picker_controller.cc (working copy)

@@ -23,6 +23,7 @@

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_navigator.h"

+#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/intents/web_intent_picker.h"

#include "chrome/browser/ui/intents/web_intent_picker_model.h"

#include "chrome/browser/ui/tab_contents/tab_contents.h"

@@ -282,7 +283,7 @@

case WebIntentPickerModel::DISPOSITION_WINDOW: {

Browser* browser = browser::FindBrowserWithWebContents(

tab_contents_->web_contents());

- TabContents* contents = Browser::TabContentsFactory(

+ TabContents* contents = chrome::TabContentsFactory(

tab_contents_->profile(),

tab_util::GetSiteInstanceForNewTab(

tab_contents_->profile(), url),

@@ -428,7 +429,7 @@

if (source_browser) {

int source_index = source_browser->tab_strip_model()->

GetIndexOfTabContents(tab_contents_);

- source_browser->ActivateTabAt(source_index, false);

+ chrome::ActivateTabAt(source_browser, source_index, false);

}

service_tab_ = NULL;