chrome/browser/extensions/window_open_apitest.cc - Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_inline_install_browsertest.cc ('k') | chrome/browser/external_extension_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/window_open_apitest.cc

===================================================================

--- chrome/browser/extensions/window_open_apitest.cc (revision 145001)

+++ chrome/browser/extensions/window_open_apitest.cc (working copy)

@@ -10,6 +10,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/test/base/ui_test_utils.h"

@@ -263,7 +264,7 @@

last_loaded_extension_id_ + "/test.html");

ui_test_utils::NavigateToURL(browser(), start_url);

WebContents* newtab;

- ASSERT_NO_FATAL_FAILURE(OpenWindow(browser()->GetActiveWebContents(),

+ ASSERT_NO_FATAL_FAILURE(OpenWindow(chrome::GetActiveWebContents(browser()),

start_url.Resolve("newtab.html"), true, &newtab));

bool result = false;

@@ -281,7 +282,7 @@

GURL start_url(std::string("chrome-extension://") +

last_loaded_extension_id_ + "/test.html");

ui_test_utils::NavigateToURL(browser(), start_url);

- ASSERT_NO_FATAL_FAILURE(OpenWindow(browser()->GetActiveWebContents(),

+ ASSERT_NO_FATAL_FAILURE(OpenWindow(chrome::GetActiveWebContents(browser()),

GURL("chrome-extension://thisissurelynotavalidextensionid/newtab.html"),

false, NULL));

@@ -298,7 +299,7 @@

ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));

WebContents* newtab;

- ASSERT_NO_FATAL_FAILURE(OpenWindow(browser()->GetActiveWebContents(),

+ ASSERT_NO_FATAL_FAILURE(OpenWindow(chrome::GetActiveWebContents(browser()),

GURL(std::string("chrome-extension://") + last_loaded_extension_id_ +

"/newtab.html"), false, &newtab));