Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/lazy_background_page_apitest.cc
===================================================================
--- chrome/browser/extensions/lazy_background_page_apitest.cc (revision 145001)
+++ chrome/browser/extensions/lazy_background_page_apitest.cc (working copy)
@@ -16,6 +16,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/omnibox/location_bar.h"
#include "chrome/common/chrome_notification_types.h"
@@ -111,7 +112,7 @@
EXPECT_FALSE(pm->GetBackgroundHostForExtension(last_loaded_extension_id_));
EXPECT_EQ(num_tabs_before + 1, browser()->tab_count());
EXPECT_EQ("chrome://chrome/extensions/",
- browser()->GetActiveWebContents()->GetURL().spec());
+ chrome::GetActiveWebContents(browser())->GetURL().spec());
}
IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest,
@@ -192,7 +193,7 @@
// The extension should've opened a new tab to an extension page.
EXPECT_EQ(extension->GetResourceURL("extension_page.html").spec(),
- browser()->GetActiveWebContents()->GetURL().spec());
+ chrome::GetActiveWebContents(browser())->GetURL().spec());
// Lazy Background Page still exists, because the extension created a new tab
// to an extension page.
@@ -201,7 +202,7 @@
EXPECT_TRUE(pm->GetBackgroundHostForExtension(last_loaded_extension_id_));
// Close the new tab.
- browser()->CloseTabContents(browser()->GetActiveWebContents());
+ chrome::CloseWebContents(browser(), chrome::GetActiveWebContents(browser()));
page_complete.Wait();
// Lazy Background Page has been shut down.
« no previous file with comments | « chrome/browser/extensions/isolated_app_browsertest.cc ('k') | chrome/browser/extensions/options_page_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698