Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/ui/views/ash/app_list/search_builder.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/ash/app_list/search_builder.h" 5 #include "chrome/browser/ui/views/ash/app_list/search_builder.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "ash/ash_switches.h" 9 #include "ash/ash_switches.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "chrome/browser/autocomplete/autocomplete.h" 11 #include "chrome/browser/autocomplete/autocomplete.h"
12 #include "chrome/browser/autocomplete/autocomplete_controller.h" 12 #include "chrome/browser/autocomplete/autocomplete_controller.h"
13 #include "chrome/browser/autocomplete/autocomplete_match.h" 13 #include "chrome/browser/autocomplete/autocomplete_match.h"
14 #include "chrome/browser/autocomplete/extension_app_provider.h" 14 #include "chrome/browser/autocomplete/extension_app_provider.h"
15 #include "chrome/browser/event_disposition.h" 15 #include "chrome/browser/event_disposition.h"
16 #include "chrome/browser/extensions/extension_service.h" 16 #include "chrome/browser/extensions/extension_service.h"
17 #include "chrome/browser/extensions/image_loading_tracker.h" 17 #include "chrome/browser/extensions/image_loading_tracker.h"
18 #include "chrome/browser/profiles/profile.h" 18 #include "chrome/browser/profiles/profile.h"
19 #include "chrome/browser/ui/browser.h" 19 #include "chrome/browser/ui/browser.h"
20 #include "chrome/browser/ui/browser_finder.h" 20 #include "chrome/browser/ui/browser_finder.h"
21 #include "chrome/browser/ui/browser_tabstrip.h"
21 #include "chrome/browser/ui/views/ash/extension_utils.h" 22 #include "chrome/browser/ui/views/ash/extension_utils.h"
22 #include "chrome/common/extensions/extension.h" 23 #include "chrome/common/extensions/extension.h"
23 #include "chrome/common/extensions/extension_icon_set.h" 24 #include "chrome/common/extensions/extension_icon_set.h"
24 #include "chrome/common/url_constants.h" 25 #include "chrome/common/url_constants.h"
25 #include "content/public/browser/web_contents.h" 26 #include "content/public/browser/web_contents.h"
26 #include "grit/generated_resources.h" 27 #include "grit/generated_resources.h"
27 #include "grit/theme_resources_standard.h" 28 #include "grit/theme_resources_standard.h"
28 #include "ui/app_list/search_box_model.h" 29 #include "ui/app_list/search_box_model.h"
29 #include "ui/app_list/search_result.h" 30 #include "ui/app_list/search_result.h"
30 #include "ui/base/l10n/l10n_util.h" 31 #include "ui/base/l10n/l10n_util.h"
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 GetExtensionByURL(profile_, match.destination_url); 236 GetExtensionByURL(profile_, match.destination_url);
236 if (extension) 237 if (extension)
237 extension_utils::OpenExtension(profile_, extension, event_flags); 238 extension_utils::OpenExtension(profile_, extension, event_flags);
238 } else { 239 } else {
239 WindowOpenDisposition disposition = 240 WindowOpenDisposition disposition =
240 browser::DispositionFromEventFlags(event_flags); 241 browser::DispositionFromEventFlags(event_flags);
241 Browser* browser = browser::FindOrCreateTabbedBrowser(profile_); 242 Browser* browser = browser::FindOrCreateTabbedBrowser(profile_);
242 243
243 if (disposition == CURRENT_TAB) { 244 if (disposition == CURRENT_TAB) {
244 // If current tab is not NTP, change disposition to NEW_FOREGROUND_TAB. 245 // If current tab is not NTP, change disposition to NEW_FOREGROUND_TAB.
245 const GURL& url = browser->GetActiveWebContents() ? 246 const GURL& url = chrome::GetActiveWebContents(browser) ?
246 browser->GetActiveWebContents()->GetURL() : GURL(); 247 chrome::GetActiveWebContents(browser)->GetURL() : GURL();
247 if (!url.SchemeIs(chrome::kChromeUIScheme) || 248 if (!url.SchemeIs(chrome::kChromeUIScheme) ||
248 url.host() != chrome::kChromeUINewTabHost) { 249 url.host() != chrome::kChromeUINewTabHost) {
249 disposition = NEW_FOREGROUND_TAB; 250 disposition = NEW_FOREGROUND_TAB;
250 } 251 }
251 } 252 }
252 253
253 // TODO(xiyuan): What should we do for alternate url case? 254 // TODO(xiyuan): What should we do for alternate url case?
254 browser->OpenURL( 255 browser->OpenURL(
255 content::OpenURLParams(match.destination_url, 256 content::OpenURLParams(match.destination_url,
256 content::Referrer(), 257 content::Referrer(),
(...skipping 10 matching lines...) Expand all
267 ++it) { 268 ++it) {
268 results_->Add(new SearchBuilderResult(profile_, *it)); 269 results_->Add(new SearchBuilderResult(profile_, *it));
269 } 270 }
270 } 271 }
271 272
272 void SearchBuilder::OnResultChanged(bool default_match_changed) { 273 void SearchBuilder::OnResultChanged(bool default_match_changed) {
273 // TODO(xiyuan): Handle default match properly. 274 // TODO(xiyuan): Handle default match properly.
274 const AutocompleteResult& ac_result = controller_->result(); 275 const AutocompleteResult& ac_result = controller_->result();
275 PopulateFromACResult(ac_result); 276 PopulateFromACResult(ac_result);
276 } 277 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698