Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4087)

Unified Diff: chrome/browser/chromeos/oom_priority_manager_browsertest.cc

Issue 10702029: Move tab functions off Browser into browser_tabstrip and browser_tabrestore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/media/media_player.cc ('k') | chrome/browser/collected_cookies_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/oom_priority_manager_browsertest.cc
===================================================================
--- chrome/browser/chromeos/oom_priority_manager_browsertest.cc (revision 145001)
+++ chrome/browser/chromeos/oom_priority_manager_browsertest.cc (working copy)
@@ -6,7 +6,9 @@
#include "chrome/browser/chromeos/oom_priority_manager.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
+#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/find_bar/find_bar_controller.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
@@ -79,22 +81,22 @@
// and was not selected.
EXPECT_TRUE(g_browser_process->oom_priority_manager()->DiscardTab());
EXPECT_EQ(3, browser()->tab_count());
- EXPECT_TRUE(browser()->IsTabDiscarded(0));
- EXPECT_FALSE(browser()->IsTabDiscarded(1));
- EXPECT_FALSE(browser()->IsTabDiscarded(2));
+ EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(0));
+ EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(1));
+ EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(2));
// Run discard again, make sure it kills the second tab.
g_browser_process->oom_priority_manager()->DiscardTab();
EXPECT_EQ(3, browser()->tab_count());
- EXPECT_TRUE(browser()->IsTabDiscarded(0));
- EXPECT_TRUE(browser()->IsTabDiscarded(1));
- EXPECT_FALSE(browser()->IsTabDiscarded(2));
+ EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(0));
+ EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(1));
+ EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(2));
// Kill the third tab
EXPECT_TRUE(g_browser_process->oom_priority_manager()->DiscardTab());
- EXPECT_TRUE(browser()->IsTabDiscarded(0));
- EXPECT_TRUE(browser()->IsTabDiscarded(1));
- EXPECT_TRUE(browser()->IsTabDiscarded(2));
+ EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(0));
+ EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(1));
+ EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(2));
// Running when all tabs are discarded should do nothing.
EXPECT_FALSE(g_browser_process->oom_priority_manager()->DiscardTab());
@@ -110,11 +112,11 @@
reload1.Wait();
// Make sure the FindBarController gets the right TabContents.
EXPECT_EQ(browser()->GetFindBarController()->tab_contents(),
- browser()->GetActiveTabContents());
+ chrome::GetActiveTabContents(browser()));
EXPECT_EQ(0, browser()->active_index());
- EXPECT_FALSE(browser()->IsTabDiscarded(0));
- EXPECT_TRUE(browser()->IsTabDiscarded(1));
- EXPECT_TRUE(browser()->IsTabDiscarded(2));
+ EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(0));
+ EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(1));
+ EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(2));
// Select the third tab. It should reload.
WindowedNotificationObserver reload2(
@@ -123,9 +125,9 @@
chrome::SelectNumberedTab(browser(), 2);
reload2.Wait();
EXPECT_EQ(2, browser()->active_index());
- EXPECT_FALSE(browser()->IsTabDiscarded(0));
- EXPECT_TRUE(browser()->IsTabDiscarded(1));
- EXPECT_FALSE(browser()->IsTabDiscarded(2));
+ EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(0));
+ EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(1));
+ EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(2));
// Navigate the third tab back twice. We used to crash here due to
// crbug.com/121373.
« no previous file with comments | « chrome/browser/chromeos/media/media_player.cc ('k') | chrome/browser/collected_cookies_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698