Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed)

Created:
7 years, 3 months ago by eseidel
Modified:
7 years, 3 months ago
CC:
blink-reviews, shans, webcomponents-bugzilla_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, blink-layers+watch_chromium.org, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, nessy, pdr, loislo+blink_chromium.org, Steve Block, dino_apple.com, do-not-use, Nils Barth (inactive), jamesr, caseq+blink_chromium.org, Nate Chapin, aboxhall, marja+watch_chromium.org, dsinclair, dglazkov+blink, abarth-chromium, aandrey+blink_chromium.org, dstockwell, Timothy Loh, Rik, gavinp+loader_chromium.org, danakj, devtools-reviews_chromium.org, pdr., Eric Willigers, alancutter (OOO until 2018), rjwright, jchaffraix+rendering, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, dmazzoni, darktears, haraken, kojih, vcarbune.chromium, jsbell+bindings_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), paulirish+reviews_chromium.org, f(malita), chromiumbugtracker_adobe.com, Stephen Chennney, jeez
Visibility:
Public.

Description

WTF::notFound looks too much like a local variable. I discovered this as part of attempting to deploy -Wshadow. There was one place (HashMap.h) where we had a notFound local. Changing notFound to kNotFound also made it look pretty in my editor. This sorta seems like a silly change, but I do believe it will help code readability. I think it was a mistake to have a global constant beginging with a lowercase letter in the first place. BUG=294205 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -359 lines) Patch
M Source/bindings/v8/ScriptGCEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8PerIsolateData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AccessibilityScrollView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSSelectorList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleSet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CustomElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/EventListenerMap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/EventSender.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ContentDistribution.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/InputMethodController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InputMethodController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextInsertionBaseCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextIterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/markup.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/EmailInputType.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/FormController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDimension.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLImportLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaFragmentURIParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/NumberInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLFormattingElementList.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLMetaCharsetParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackCueList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackRegion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackRegionList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/WebVTTParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/ContentSearchUtils.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/TimelineTraceEventProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/TimelineTraceEventProcessor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/loader/CrossOriginPreflightResultCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/UserContentURLPattern.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/WindowFeatures.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/platform/ContentType.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/platform/Length.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/MIMETypeFromURL.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/ImageSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/SVGGlyph.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/image-decoders/ImageDecoder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/image-decoders/ImageDecoder.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/image-decoders/ImageDecoderTest.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M Source/core/platform/image-decoders/ImageFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/image-decoders/gif/GIFImageDecoder.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/image-decoders/gif/GIFImageReader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/image-decoders/ico/ICOImageDecoder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/mediastream/MediaStreamDescriptor.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/platform/mediastream/MediaStreamSource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/network/HTTPParsers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/network/MIMEHeader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/network/ParsedContentType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/network/ResourceResponse.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/platform/text/DateTimeFormat.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/text/DecodeEscapeSequences.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/LocaleToScriptMappingDefault.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/mac/LocaleMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/win/LocaleWin.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderGeometryMap.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGURIReference.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/tests/ArenaTestHelpers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/xml/XPathParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceSensorEventDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMFilePath.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/SourceBufferList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBufferList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/WebKitSourceBufferList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocketExtensionDispatcherTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/PageOverlayList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PageOverlayList.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/painting/ContinuousPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/weborigin/DatabaseIdentifier.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/weborigin/SecurityPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/HashMap.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/wtf/HashTraits.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/wtf/NotFound.h View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/wtf/Vector.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/wtf/text/StringImpl.h View 7 chunks +10 lines, -10 lines 0 comments Download
M Source/wtf/text/StringImpl.cpp View 28 chunks +33 lines, -33 lines 0 comments Download
M Source/wtf/text/TextPosition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/WTFString.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/wtf/text/WTFString.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
7 years, 3 months ago (2013-09-19 18:00:40 UTC) #1
abarth-chromium
LGTM
7 years, 3 months ago (2013-09-19 18:35:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/23464095/1
7 years, 3 months ago (2013-09-19 19:39:58 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 22:04:59 UTC) #4
Message was sent while issue was closed.
Change committed as 158058

Powered by Google App Engine
This is Rietveld 408576698