Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: Source/core/platform/Length.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/platform/ContentType.cpp ('k') | Source/core/platform/MIMETypeFromURL.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller ( mueller@kde.org ) 4 * (C) 2001 Dirk Mueller ( mueller@kde.org )
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.
6 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net) 6 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 if (!str->length()) 92 if (!str->length())
93 return Vector<Length>(); 93 return Vector<Length>();
94 94
95 unsigned len = str->count(' ') + 1; 95 unsigned len = str->count(' ') + 1;
96 Vector<Length> r(len); 96 Vector<Length> r(len);
97 97
98 int i = 0; 98 int i = 0;
99 unsigned pos = 0; 99 unsigned pos = 0;
100 size_t pos2; 100 size_t pos2;
101 101
102 while ((pos2 = str->find(' ', pos)) != notFound) { 102 while ((pos2 = str->find(' ', pos)) != kNotFound) {
103 r[i++] = parseHTMLAreaCoordinate(str->characters8() + pos, pos2 - pos); 103 r[i++] = parseHTMLAreaCoordinate(str->characters8() + pos, pos2 - pos);
104 pos = pos2 + 1; 104 pos = pos2 + 1;
105 } 105 }
106 r[i] = parseHTMLAreaCoordinate(str->characters8() + pos, str->length() - pos ); 106 r[i] = parseHTMLAreaCoordinate(str->characters8() + pos, str->length() - pos );
107 107
108 ASSERT(i == len - 1); 108 ASSERT(i == len - 1);
109 109
110 return r; 110 return r;
111 } 111 }
112 112
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 return isCalculated() && (calculationValue() == o.calculationValue() || *cal culationValue() == *o.calculationValue()); 210 return isCalculated() && (calculationValue() == o.calculationValue() || *cal culationValue() == *o.calculationValue());
211 } 211 }
212 212
213 struct SameSizeAsLength { 213 struct SameSizeAsLength {
214 int32_t value; 214 int32_t value;
215 int32_t metaData; 215 int32_t metaData;
216 }; 216 };
217 COMPILE_ASSERT(sizeof(Length) == sizeof(SameSizeAsLength), length_should_stay_sm all); 217 COMPILE_ASSERT(sizeof(Length) == sizeof(SameSizeAsLength), length_should_stay_sm all);
218 218
219 } // namespace WebCore 219 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/platform/ContentType.cpp ('k') | Source/core/platform/MIMETypeFromURL.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698