Source/core/inspector/TimelineTraceEventProcessor.h - Issue 23464095: WTF::notFound looks too much like a local variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/TimelineTraceEventProcessor.h

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/TimelineTraceEventProcessor.h

diff --git a/Source/core/inspector/TimelineTraceEventProcessor.h b/Source/core/inspector/TimelineTraceEventProcessor.h

index d710b3a8d99f1b5e95730bd93dffada0a623f652..e9b386ec05d945fe67ccb8ec0a74d8ed3b06796e 100644

--- a/Source/core/inspector/TimelineTraceEventProcessor.h

+++ b/Source/core/inspector/TimelineTraceEventProcessor.h

@@ -175,7 +175,7 @@ private:

long long asInt(const char* name) const

{

size_t index = findParameter(name);

- if (index == notFound || (m_argumentTypes[index] != TypeInt && m_argumentTypes[index] != TypeUInt)) {

+ if (index == kNotFound || (m_argumentTypes[index] != TypeInt && m_argumentTypes[index] != TypeUInt)) {

ASSERT_NOT_REACHED();

return 0;

}