Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: Source/bindings/v8/ScriptGCEvent.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/v8/V8PerIsolateData.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 } 55 }
56 listeners.append(eventListener); 56 listeners.append(eventListener);
57 } 57 }
58 58
59 void ScriptGCEvent::removeEventListener(ScriptGCEventListener* eventListener) 59 void ScriptGCEvent::removeEventListener(ScriptGCEventListener* eventListener)
60 { 60 {
61 ASSERT(eventListener); 61 ASSERT(eventListener);
62 GCEventData::GCEventListeners& listeners = isolateGCEventData()->listeners() ; 62 GCEventData::GCEventListeners& listeners = isolateGCEventData()->listeners() ;
63 ASSERT(!listeners.isEmpty()); 63 ASSERT(!listeners.isEmpty());
64 size_t i = listeners.find(eventListener); 64 size_t i = listeners.find(eventListener);
65 ASSERT(i != notFound); 65 ASSERT(i != kNotFound);
66 listeners.remove(i); 66 listeners.remove(i);
67 if (listeners.isEmpty()) { 67 if (listeners.isEmpty()) {
68 v8::V8::RemoveGCPrologueCallback(ScriptGCEvent::gcPrologueCallback); 68 v8::V8::RemoveGCPrologueCallback(ScriptGCEvent::gcPrologueCallback);
69 v8::V8::RemoveGCEpilogueCallback(ScriptGCEvent::gcEpilogueCallback); 69 v8::V8::RemoveGCEpilogueCallback(ScriptGCEvent::gcEpilogueCallback);
70 } 70 }
71 } 71 }
72 72
73 void ScriptGCEvent::getHeapSize(HeapInfo& info) 73 void ScriptGCEvent::getHeapSize(HeapInfo& info)
74 { 74 {
75 v8::HeapStatistics heapStatistics; 75 v8::HeapStatistics heapStatistics;
(...skipping 26 matching lines...) Expand all
102 size_t usedHeapSize = getUsedHeapSize(); 102 size_t usedHeapSize = getUsedHeapSize();
103 size_t collectedBytes = usedHeapSize > gcEventData->usedHeapSize() ? 0 : gcE ventData->usedHeapSize() - usedHeapSize; 103 size_t collectedBytes = usedHeapSize > gcEventData->usedHeapSize() ? 0 : gcE ventData->usedHeapSize() - usedHeapSize;
104 GCEventData::GCEventListeners& listeners = gcEventData->listeners(); 104 GCEventData::GCEventListeners& listeners = gcEventData->listeners();
105 for (GCEventData::GCEventListeners::iterator i = listeners.begin(); i != lis teners.end(); ++i) 105 for (GCEventData::GCEventListeners::iterator i = listeners.begin(); i != lis teners.end(); ++i)
106 (*i)->didGC(gcEventData->startTime(), endTime, collectedBytes); 106 (*i)->didGC(gcEventData->startTime(), endTime, collectedBytes);
107 gcEventData->clear(); 107 gcEventData->clear();
108 } 108 }
109 109
110 } // namespace WebCore 110 } // namespace WebCore
111 111
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/V8PerIsolateData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698