Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: Source/core/rendering/RenderTable.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | Source/core/rendering/svg/RenderSVGText.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 if (beforeChild && !beforeChild->isTableSection() && beforeChild->style()->d isplay() != TABLE_CAPTION && beforeChild->style()->display() != TABLE_COLUMN_GRO UP) 193 if (beforeChild && !beforeChild->isTableSection() && beforeChild->style()->d isplay() != TABLE_CAPTION && beforeChild->style()->display() != TABLE_COLUMN_GRO UP)
194 beforeChild = 0; 194 beforeChild = 0;
195 195
196 RenderTableSection* section = RenderTableSection::createAnonymousWithParentR enderer(this); 196 RenderTableSection* section = RenderTableSection::createAnonymousWithParentR enderer(this);
197 addChild(section, beforeChild); 197 addChild(section, beforeChild);
198 section->addChild(child); 198 section->addChild(child);
199 } 199 }
200 200
201 void RenderTable::addCaption(const RenderTableCaption* caption) 201 void RenderTable::addCaption(const RenderTableCaption* caption)
202 { 202 {
203 ASSERT(m_captions.find(caption) == notFound); 203 ASSERT(m_captions.find(caption) == kNotFound);
204 m_captions.append(const_cast<RenderTableCaption*>(caption)); 204 m_captions.append(const_cast<RenderTableCaption*>(caption));
205 } 205 }
206 206
207 void RenderTable::removeCaption(const RenderTableCaption* oldCaption) 207 void RenderTable::removeCaption(const RenderTableCaption* oldCaption)
208 { 208 {
209 size_t index = m_captions.find(oldCaption); 209 size_t index = m_captions.find(oldCaption);
210 ASSERT(index != notFound); 210 ASSERT(index != kNotFound);
211 if (index == notFound) 211 if (index == kNotFound)
212 return; 212 return;
213 213
214 m_captions.remove(index); 214 m_captions.remove(index);
215 } 215 }
216 216
217 void RenderTable::invalidateCachedColumns() 217 void RenderTable::invalidateCachedColumns()
218 { 218 {
219 m_columnRenderersValid = false; 219 m_columnRenderersValid = false;
220 m_columnRenderers.resize(0); 220 m_columnRenderers.resize(0);
221 } 221 }
(...skipping 1217 matching lines...) Expand 10 before | Expand all | Expand 10 after
1439 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const 1439 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const
1440 { 1440 {
1441 ASSERT(cell->isFirstOrLastCellInRow()); 1441 ASSERT(cell->isFirstOrLastCellInRow());
1442 if (hasSameDirectionAs(cell->row())) 1442 if (hasSameDirectionAs(cell->row()))
1443 return style()->borderEnd(); 1443 return style()->borderEnd();
1444 1444
1445 return style()->borderStart(); 1445 return style()->borderStart();
1446 } 1446 }
1447 1447
1448 } 1448 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | Source/core/rendering/svg/RenderSVGText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698