Source/core/platform/mediastream/MediaStreamDescriptor.cpp - Issue 23464095: WTF::notFound looks too much like a local variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/mediastream/MediaStreamDescriptor.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/platform/image-decoders/webp/WEBPImageDecoderTest.cpp ('k') | Source/core/platform/mediastream/MediaStreamSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/mediastream/MediaStreamDescriptor.cpp

diff --git a/Source/core/platform/mediastream/MediaStreamDescriptor.cpp b/Source/core/platform/mediastream/MediaStreamDescriptor.cpp

index 6d01fb245a84952613d1629bcbf514f07fd69bb4..cb1ae44d3662398071a5667f49db3801452635c6 100644

--- a/Source/core/platform/mediastream/MediaStreamDescriptor.cpp

+++ b/Source/core/platform/mediastream/MediaStreamDescriptor.cpp

@@ -55,11 +55,11 @@ void MediaStreamDescriptor::addComponent(PassRefPtr<MediaStreamComponent> compon

{

switch (component->source()->type()) {

case MediaStreamSource::TypeAudio:

- if (m_audioComponents.find(component) == notFound)

+ if (m_audioComponents.find(component) == kNotFound)

m_audioComponents.append(component);

break;

case MediaStreamSource::TypeVideo:

- if (m_videoComponents.find(component) == notFound)

+ if (m_videoComponents.find(component) == kNotFound)

m_videoComponents.append(component);

break;

}

@@ -67,16 +67,16 @@ void MediaStreamDescriptor::addComponent(PassRefPtr<MediaStreamComponent> compon

void MediaStreamDescriptor::removeComponent(PassRefPtr<MediaStreamComponent> component)

{

- size_t pos = notFound;

+ size_t pos = kNotFound;

switch (component->source()->type()) {

case MediaStreamSource::TypeAudio:

pos = m_audioComponents.find(component);

- if (pos != notFound)

+ if (pos != kNotFound)

m_audioComponents.remove(pos);

break;

case MediaStreamSource::TypeVideo:

pos = m_videoComponents.find(component);

- if (pos != notFound)

+ if (pos != kNotFound)

m_videoComponents.remove(pos);

break;

}