Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/MediaFragmentURIParser.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 stripped.append(character); 125 stripped.append(character);
126 } 126 }
127 return stripped.toString(); 127 return stripped.toString();
128 } 128 }
129 129
130 static bool isNotLineBreak(UChar ch) { return ch != newlineCharacter && ch != ca rriageReturn; } 130 static bool isNotLineBreak(UChar ch) { return ch != newlineCharacter && ch != ca rriageReturn; }
131 131
132 bool HTMLTextFormControlElement::isPlaceholderEmpty() const 132 bool HTMLTextFormControlElement::isPlaceholderEmpty() const
133 { 133 {
134 const AtomicString& attributeValue = fastGetAttribute(placeholderAttr); 134 const AtomicString& attributeValue = fastGetAttribute(placeholderAttr);
135 return attributeValue.string().find(isNotLineBreak) == notFound; 135 return attributeValue.string().find(isNotLineBreak) == kNotFound;
136 } 136 }
137 137
138 bool HTMLTextFormControlElement::placeholderShouldBeVisible() const 138 bool HTMLTextFormControlElement::placeholderShouldBeVisible() const
139 { 139 {
140 return supportsPlaceholder() 140 return supportsPlaceholder()
141 && isEmptyValue() 141 && isEmptyValue()
142 && isEmptySuggestedValue() 142 && isEmptySuggestedValue()
143 && !isPlaceholderEmpty() 143 && !isPlaceholderEmpty()
144 && (document().focusedElement() != this || (RenderTheme::theme().shouldS howPlaceholderWhenFocused())) 144 && (document().focusedElement() != this || (RenderTheme::theme().shouldS howPlaceholderWhenFocused()))
145 && (!renderer() || renderer()->style()->visibility() == VISIBLE); 145 && (!renderer() || renderer()->style()->visibility() == VISIBLE);
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 bool isAuto; 645 bool isAuto;
646 TextDirection textDirection = static_cast<const HTMLElement*>(elemen t)->directionalityIfhasDirAutoAttribute(isAuto); 646 TextDirection textDirection = static_cast<const HTMLElement*>(elemen t)->directionalityIfhasDirAutoAttribute(isAuto);
647 return textDirection == RTL ? "rtl" : "ltr"; 647 return textDirection == RTL ? "rtl" : "ltr";
648 } 648 }
649 } 649 }
650 650
651 return "ltr"; 651 return "ltr";
652 } 652 }
653 653
654 } // namespace Webcore 654 } // namespace Webcore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/MediaFragmentURIParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698