Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: Source/modules/device_orientation/DeviceSensorEventDispatcher.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/xml/XPathParser.cpp ('k') | Source/modules/filesystem/DOMFilePath.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 54
55 void DeviceSensorEventDispatcher::removeController(DeviceSensorEventController* controller) 55 void DeviceSensorEventDispatcher::removeController(DeviceSensorEventController* controller)
56 { 56 {
57 // Do not actually remove the controller from the vector, instead zero them out. 57 // Do not actually remove the controller from the vector, instead zero them out.
58 // The zeros are removed in these two cases: 58 // The zeros are removed in these two cases:
59 // 1. either immediately if we are not dispatching any events, 59 // 1. either immediately if we are not dispatching any events,
60 // 2. or after didChangeDeviceMotion/Orientation has dispatched all events. 60 // 2. or after didChangeDeviceMotion/Orientation has dispatched all events.
61 // This is to correctly handle the re-entrancy case when a controller is des troyed 61 // This is to correctly handle the re-entrancy case when a controller is des troyed
62 // while in the didChangeDeviceMotion/Orientation method. 62 // while in the didChangeDeviceMotion/Orientation method.
63 size_t index = m_controllers.find(controller); 63 size_t index = m_controllers.find(controller);
64 if (index == notFound) 64 if (index == kNotFound)
65 return; 65 return;
66 66
67 m_controllers[index] = 0; 67 m_controllers[index] = 0;
68 m_needsPurge = true; 68 m_needsPurge = true;
69 69
70 if (!m_isDispatching) 70 if (!m_isDispatching)
71 purgeControllers(); 71 purgeControllers();
72 } 72 }
73 73
74 void DeviceSensorEventDispatcher::purgeControllers() 74 void DeviceSensorEventDispatcher::purgeControllers()
(...skipping 10 matching lines...) Expand all
85 } 85 }
86 } 86 }
87 87
88 m_needsPurge = false; 88 m_needsPurge = false;
89 89
90 if (m_controllers.isEmpty()) 90 if (m_controllers.isEmpty())
91 stopListening(); 91 stopListening();
92 } 92 }
93 93
94 } // namespace WebCore 94 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/xml/XPathParser.cpp ('k') | Source/modules/filesystem/DOMFilePath.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698