Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: Source/core/page/Chrome.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | Source/core/page/UserContentURLPattern.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2012, Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012, Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 401
402 void Chrome::registerPopupOpeningObserver(PopupOpeningObserver* observer) 402 void Chrome::registerPopupOpeningObserver(PopupOpeningObserver* observer)
403 { 403 {
404 ASSERT(observer); 404 ASSERT(observer);
405 m_popupOpeningObservers.append(observer); 405 m_popupOpeningObservers.append(observer);
406 } 406 }
407 407
408 void Chrome::unregisterPopupOpeningObserver(PopupOpeningObserver* observer) 408 void Chrome::unregisterPopupOpeningObserver(PopupOpeningObserver* observer)
409 { 409 {
410 size_t index = m_popupOpeningObservers.find(observer); 410 size_t index = m_popupOpeningObservers.find(observer);
411 ASSERT(index != notFound); 411 ASSERT(index != kNotFound);
412 m_popupOpeningObservers.remove(index); 412 m_popupOpeningObservers.remove(index);
413 } 413 }
414 414
415 void Chrome::notifyPopupOpeningObservers() const 415 void Chrome::notifyPopupOpeningObservers() const
416 { 416 {
417 const Vector<PopupOpeningObserver*> observers(m_popupOpeningObservers); 417 const Vector<PopupOpeningObserver*> observers(m_popupOpeningObservers);
418 for (size_t i = 0; i < observers.size(); ++i) 418 for (size_t i = 0; i < observers.size(); ++i)
419 observers[i]->willOpenPopup(); 419 observers[i]->willOpenPopup();
420 } 420 }
421 421
422 } // namespace WebCore 422 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | Source/core/page/UserContentURLPattern.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698