Source/core/html/HTMLTextFormControlElement.cpp - Issue 23464095: WTF::notFound looks too much like a local variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp

index 4887402dcb3c132fe8158a8d9160fbcc627cded0..dd3f8fa0aa02ab28300051677f675adf97af9823 100644

--- a/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/Source/core/html/HTMLTextFormControlElement.cpp

@@ -132,7 +132,7 @@ static bool isNotLineBreak(UChar ch) { return ch != newlineCharacter && ch != ca

bool HTMLTextFormControlElement::isPlaceholderEmpty() const

{

const AtomicString& attributeValue = fastGetAttribute(placeholderAttr);

- return attributeValue.string().find(isNotLineBreak) == notFound;

+ return attributeValue.string().find(isNotLineBreak) == kNotFound;

}

bool HTMLTextFormControlElement::placeholderShouldBeVisible() const

« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/MediaFragmentURIParser.cpp » ('j') | no next file with comments »