Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: Source/core/html/HTMLEmbedElement.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLDimension.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights reserv ed.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 } 89 }
90 } else 90 } else
91 HTMLPlugInImageElement::collectStyleForPresentationAttribute(name, value , style); 91 HTMLPlugInImageElement::collectStyleForPresentationAttribute(name, value , style);
92 } 92 }
93 93
94 void HTMLEmbedElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value) 94 void HTMLEmbedElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value)
95 { 95 {
96 if (name == typeAttr) { 96 if (name == typeAttr) {
97 m_serviceType = value.string().lower(); 97 m_serviceType = value.string().lower();
98 size_t pos = m_serviceType.find(";"); 98 size_t pos = m_serviceType.find(";");
99 if (pos != notFound) 99 if (pos != kNotFound)
100 m_serviceType = m_serviceType.left(pos); 100 m_serviceType = m_serviceType.left(pos);
101 } else if (name == codeAttr) 101 } else if (name == codeAttr)
102 m_url = stripLeadingAndTrailingHTMLSpaces(value); 102 m_url = stripLeadingAndTrailingHTMLSpaces(value);
103 else if (name == srcAttr) { 103 else if (name == srcAttr) {
104 m_url = stripLeadingAndTrailingHTMLSpaces(value); 104 m_url = stripLeadingAndTrailingHTMLSpaces(value);
105 if (renderer() && isImageType()) { 105 if (renderer() && isImageType()) {
106 if (!m_imageLoader) 106 if (!m_imageLoader)
107 m_imageLoader = adoptPtr(new HTMLImageLoader(this)); 107 m_imageLoader = adoptPtr(new HTMLImageLoader(this));
108 m_imageLoader->updateFromElementIgnoringPreviousError(); 108 m_imageLoader->updateFromElementIgnoringPreviousError();
109 } 109 }
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 } 204 }
205 205
206 void HTMLEmbedElement::addSubresourceAttributeURLs(ListHashSet<KURL>& urls) cons t 206 void HTMLEmbedElement::addSubresourceAttributeURLs(ListHashSet<KURL>& urls) cons t
207 { 207 {
208 HTMLPlugInImageElement::addSubresourceAttributeURLs(urls); 208 HTMLPlugInImageElement::addSubresourceAttributeURLs(urls);
209 209
210 addSubresourceURL(urls, document().completeURL(getAttribute(srcAttr))); 210 addSubresourceURL(urls, document().completeURL(getAttribute(srcAttr)));
211 } 211 }
212 212
213 } 213 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLDimension.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698