Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Side by Side Diff: Source/core/html/track/TextTrackCueList.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/track/TextTrackCue.cpp ('k') | Source/core/html/track/TextTrackList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 size_t index = (start + end) / 2; 102 size_t index = (start + end) / 2;
103 if (cue->startTime() < m_list[index]->startTime() || (cue->startTime() == m_ list[index]->startTime() && cue->endTime() > m_list[index]->endTime())) 103 if (cue->startTime() < m_list[index]->startTime() || (cue->startTime() == m_ list[index]->startTime() && cue->endTime() > m_list[index]->endTime()))
104 return add(cue.release(), start, index); 104 return add(cue.release(), start, index);
105 105
106 return add(cue.release(), index + 1, end); 106 return add(cue.release(), index + 1, end);
107 } 107 }
108 108
109 bool TextTrackCueList::remove(TextTrackCue* cue) 109 bool TextTrackCueList::remove(TextTrackCue* cue)
110 { 110 {
111 size_t index = m_list.find(cue); 111 size_t index = m_list.find(cue);
112 if (index == notFound) 112 if (index == kNotFound)
113 return false; 113 return false;
114 114
115 cue->setIsActive(false); 115 cue->setIsActive(false);
116 m_list.remove(index); 116 m_list.remove(index);
117 return true; 117 return true;
118 } 118 }
119 119
120 bool TextTrackCueList::contains(TextTrackCue* cue) const 120 bool TextTrackCueList::contains(TextTrackCue* cue) const
121 { 121 {
122 return m_list.contains(cue); 122 return m_list.contains(cue);
(...skipping 14 matching lines...) Expand all
137 } 137 }
138 138
139 void TextTrackCueList::invalidateCueIndexes(size_t start) 139 void TextTrackCueList::invalidateCueIndexes(size_t start)
140 { 140 {
141 for (size_t i = start; i < m_list.size(); ++i) 141 for (size_t i = start; i < m_list.size(); ++i)
142 m_list[i]->invalidateCueIndex(); 142 m_list[i]->invalidateCueIndex();
143 } 143 }
144 144
145 } // namespace WebCore 145 } // namespace WebCore
146 146
OLDNEW
« no previous file with comments | « Source/core/html/track/TextTrackCue.cpp ('k') | Source/core/html/track/TextTrackList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698