Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Side by Side Diff: Source/core/html/HTMLDimension.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLAnchorElement.cpp ('k') | Source/core/html/HTMLEmbedElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 // HTML5's split doesn't return a token for an empty string so 113 // HTML5's split doesn't return a token for an empty string so
114 // we need to match them here. 114 // we need to match them here.
115 if (trimmedString.isEmpty()) 115 if (trimmedString.isEmpty())
116 return Vector<HTMLDimension>(); 116 return Vector<HTMLDimension>();
117 117
118 // Step 3. To avoid String copies, we just look for commas instead of splitt ing. 118 // Step 3. To avoid String copies, we just look for commas instead of splitt ing.
119 Vector<HTMLDimension> parsedDimensions; 119 Vector<HTMLDimension> parsedDimensions;
120 size_t lastParsedIndex = 0; 120 size_t lastParsedIndex = 0;
121 while (true) { 121 while (true) {
122 size_t nextComma = trimmedString.find(comma, lastParsedIndex); 122 size_t nextComma = trimmedString.find(comma, lastParsedIndex);
123 if (nextComma == notFound) 123 if (nextComma == kNotFound)
124 break; 124 break;
125 125
126 parsedDimensions.append(parseDimension(trimmedString, lastParsedIndex, n extComma)); 126 parsedDimensions.append(parseDimension(trimmedString, lastParsedIndex, n extComma));
127 lastParsedIndex = nextComma + 1; 127 lastParsedIndex = nextComma + 1;
128 } 128 }
129 129
130 parsedDimensions.append(parseDimension(trimmedString, lastParsedIndex, trimm edString.length())); 130 parsedDimensions.append(parseDimension(trimmedString, lastParsedIndex, trimm edString.length()));
131 return parsedDimensions; 131 return parsedDimensions;
132 } 132 }
133 133
134 } // namespace WebCore 134 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLAnchorElement.cpp ('k') | Source/core/html/HTMLEmbedElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698