Rename Histogram.add() to addSample().

Rename Histogram.add() to addSample().

It also now automatically promotes dictionaries to DiagnosticMaps.

BUG=catapult:#2685

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/fa2c4f21907f44a7e34e1b92df2205bda1b2c135

[benjhayden, 2016-08-26 22:57:08]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-08-26 22:57:26]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2016-08-26 22:57:27]

PTAL :-)

[eakuefner, 2016-08-30 17:57:41]

lgtm

Discussed offline: keep only addSample, add JSDoc + text comment describing the
structure of the second arg.

[eakuefner, 2016-08-30 17:57:53]

Don't forget to update title/description

[benjhayden, 2016-08-30 18:23:19]

Description was changed from

==========
Split Histogram.add() to addSample(), addSampleWithDiagnostics().

addSample() throws if a second argument is passed, telling users to use
addSampleWithDiagnostics() instead.

addSampleWithDiagnostics() automatically promotes dictionaries to
DiagnosticMaps.

BUG=catapult:#2685
==========

to

==========
Rename Histogram.add() to addSample().

It also now automatically promotes dictionaries to DiagnosticMaps.

BUG=catapult:#2685
==========

[benjhayden, 2016-08-30 20:53:45]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-08-30 20:53:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2283213002/#ps80001
(title: "merge addSample/WithDiagnostics()")

[commit-bot: I haz the power, 2016-08-30 20:53:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 21:13:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:13:39]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[benjhayden, 2016-08-30 22:12:59]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-08-30 22:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2283213002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-30 22:13:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 22:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 22:29:21]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[benjhayden, 2016-08-31 04:54:54]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-08-31 04:54:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2283213002/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-31 04:55:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 05:16:39]

Description was changed from

==========
Rename Histogram.add() to addSample().

It also now automatically promotes dictionaries to DiagnosticMaps.

BUG=catapult:#2685
==========

to

==========
Rename Histogram.add() to addSample().

It also now automatically promotes dictionaries to DiagnosticMaps.

BUG=catapult:#2685

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-08-31 05:16:40]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...