Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: tracing/tracing/metrics/system_health/memory_metric.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/memory_metric.html
diff --git a/tracing/tracing/metrics/system_health/memory_metric.html b/tracing/tracing/metrics/system_health/memory_metric.html
index 52a8c4bd056aaaa0880a213df5e52dc5655aee90..88eac0de149a8a506909236ea46bb0381c79d41d 100644
--- a/tracing/tracing/metrics/system_health/memory_metric.html
+++ b/tracing/tracing/metrics/system_health/memory_metric.html
@@ -772,7 +772,7 @@ tr.exportTo('tr.metrics.sh', function() {
// Build the underlying histogram for the memory value.
var histogram = new tr.v.Histogram(unitlessNumber_smallerIsBetter,
BOUNDARIES_FOR_UNIT_MAP.get(unitlessNumber_smallerIsBetter));
- histogram.add(levelOfDetailDumpCount);
+ histogram.addSample(levelOfDetailDumpCount);
// Build the options for the memory value.
var description = [
@@ -1124,9 +1124,9 @@ tr.exportTo('tr.metrics.sh', function() {
* |node| to it.
*/
function buildMemoryNumericFromNode(node, unit) {
- var numeric = new tr.v.Histogram(unit, BOUNDARIES_FOR_UNIT_MAP.get(unit));
- node.values.forEach(v => numeric.add(v.total));
- return numeric;
+ var histogram = new tr.v.Histogram(unit, BOUNDARIES_FOR_UNIT_MAP.get(unit));
+ node.values.forEach(v => histogram.addSample(v.total));
+ return histogram;
}
tr.metrics.MetricRegistry.register(memoryMetric, {
« no previous file with comments | « tracing/tracing/metrics/system_health/long_tasks_metric.html ('k') | tracing/tracing/metrics/system_health/power_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698