tracing/tracing/metrics/system_health/rail_power_metric.html - Issue 2283213002: Rename Histogram.add() to addSample().

Side by Side Diff: tracing/tracing/metrics/system_health/rail_power_metric.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tracing/tracing/metrics/system_health/power_metric.html ('k') | tracing/tracing/metrics/system_health/responsiveness_metric.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 Copyright 2016 The Chromium Authors. All rights reserved.	3 Copyright 2016 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <link rel="import" href="/tracing/base/statistics.html">	8 <link rel="import" href="/tracing/base/statistics.html">

9 <link rel="import" href="/tracing/metrics/metric_registry.html">	9 <link rel="import" href="/tracing/metrics/metric_registry.html">

10 <link rel="import" href="/tracing/metrics/system_health/clock_sync_latency_metri c.html">	10 <link rel="import" href="/tracing/metrics/system_health/clock_sync_latency_metri c.html">

(...skipping 26 matching lines...) Expand all Loading...
37	37

38 for (var [title, durationMs] of railStageTimes) {	38 for (var [title, durationMs] of railStageTimes) {

39 var energyInJ = railStageEnergy.get(title);	39 var energyInJ = railStageEnergy.get(title);

40 var durationInMs = railStageTimes.get(title);	40 var durationInMs = railStageTimes.get(title);

41 var durationInS = tr.v.convertUnit(durationInMs,	41 var durationInS = tr.v.convertUnit(durationInMs,

42 tr.v.UnitScale.Metric.MILLI, tr.v.UnitScale.Metric.NONE);	42 tr.v.UnitScale.Metric.MILLI, tr.v.UnitScale.Metric.NONE);

43 var powerInW = energyInJ / durationInS;	43 var powerInW = energyInJ / durationInS;

44	44

45 var durationHist = new tr.v.Histogram(	45 var durationHist = new tr.v.Histogram(

46 tr.v.Unit.byName.timeDurationInMs_smallerIsBetter);	46 tr.v.Unit.byName.timeDurationInMs_smallerIsBetter);

47 durationHist.add(durationInMs);	47 durationHist.addSample(durationInMs);

48 values.addValue(new tr.v.NumericValue('total_time_' + title, durationHist,	48 values.addValue(new tr.v.NumericValue('total_time_' + title, durationHist,

49 {description: 'Time spent in RAIL stage ' + title}));	49 {description: 'Time spent in RAIL stage ' + title}));

50	50

51 var energyHist = new tr.v.Histogram(	51 var energyHist = new tr.v.Histogram(

52 tr.v.Unit.byName.energyInJoules_smallerIsBetter);	52 tr.v.Unit.byName.energyInJoules_smallerIsBetter);

53 energyHist.add(energyInJ);	53 energyHist.addSample(energyInJ);

54 values.addValue(new tr.v.NumericValue('total_energy_' + title, energyHist,	54 values.addValue(new tr.v.NumericValue('total_energy_' + title, energyHist,

55 {description: 'Energy consumed in RAIL stage ' + title}));	55 {description: 'Energy consumed in RAIL stage ' + title}));

56	56

57 var powerHist = new tr.v.Histogram(	57 var powerHist = new tr.v.Histogram(

58 tr.v.Unit.byName.powerInWatts_smallerIsBetter);	58 tr.v.Unit.byName.powerInWatts_smallerIsBetter);

59 powerHist.add(powerInW);	59 powerHist.addSample(powerInW);

60 values.addValue(new tr.v.NumericValue('energy_consumption_rate_' + title,	60 values.addValue(new tr.v.NumericValue('energy_consumption_rate_' + title,

61 powerHist, {description: 'Energy consumption rate for RAIL stage ' +	61 powerHist, {description: 'Energy consumption rate for RAIL stage ' +

62 title}));	62 title}));

63 }	63 }

64 }	64 }

65	65

66 function railPowerMetric(values, model) {	66 function railPowerMetric(values, model) {

67 if (!model.device.powerSeries)	67 if (!model.device.powerSeries)

68 return;	68 return;

69 railPowerMetricHelper(values, model);	69 railPowerMetricHelper(values, model);

70 }	70 }

71	71

72 tr.metrics.MetricRegistry.register(railPowerMetric);	72 tr.metrics.MetricRegistry.register(railPowerMetric);

73	73

74 return {	74 return {

75 railPowerMetric: railPowerMetric	75 railPowerMetric: railPowerMetric

76 };	76 };

77 });	77 });

78 </script>	78 </script>

OLD	NEW