Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: tracing/tracing/metrics/tracing_metric.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/tracing_metric.html
diff --git a/tracing/tracing/metrics/tracing_metric.html b/tracing/tracing/metrics/tracing_metric.html
index bc6db19817a79bdf74283fa3d15b0daa4aa3ab7d..9e1a25fed5c89f4acb4f9a25cb3954d3a6726b1c 100644
--- a/tracing/tracing/metrics/tracing_metric.html
+++ b/tracing/tracing/metrics/tracing_metric.html
@@ -29,7 +29,7 @@ tr.exportTo('tr.metrics', function() {
function addTimeDurationValue(valueName, duration, allValues) {
var hist = new tr.v.Histogram(
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, TIME_BOUNDARIES);
- hist.add(duration);
+ hist.addSample(duration);
allValues.addValue(new tr.v.NumericValue(valueName, hist));
}
@@ -81,14 +81,14 @@ tr.exportTo('tr.metrics', function() {
categoryNamesToTotalEventSizes.get(MEMORY_INFRA_TRACING_CATEGORY);
var memoryInfraTraceBytesValue = new tr.v.Histogram(
tr.v.Unit.byName.sizeInBytes_smallerIsBetter, BYTE_BOUNDARIES);
- memoryInfraTraceBytesValue.add(memoryInfraEventsSize);
+ memoryInfraTraceBytesValue.addSample(memoryInfraEventsSize);
values.addValue(new tr.v.NumericValue(
'Total trace size of memory-infra dumps in bytes',
memoryInfraTraceBytesValue));
var traceBytesPerDumpValue = new tr.v.Histogram(
tr.v.Unit.byName.sizeInBytes_smallerIsBetter, BYTE_BOUNDARIES);
- traceBytesPerDumpValue.add(memoryInfraEventsSize / memoryDumpCount);
+ traceBytesPerDumpValue.addSample(memoryInfraEventsSize / memoryDumpCount);
values.addValue(new tr.v.NumericValue(
'Average trace size of memory-infra dumps in bytes',
traceBytesPerDumpValue));
@@ -163,15 +163,15 @@ tr.exportTo('tr.metrics', function() {
var maxEventCountPerSecValue = new tr.v.Histogram(
tr.v.Unit.byName.count_smallerIsBetter, COUNT_BOUNDARIES);
- maxEventCountPerSecValue.add(maxEventCountPerSec);
+ maxEventCountPerSecValue.addSample(maxEventCountPerSec);
var maxEventBytesPerSecValue = new tr.v.Histogram(
tr.v.Unit.byName.sizeInBytes_smallerIsBetter, BYTE_BOUNDARIES);
- maxEventBytesPerSecValue.add(maxEventBytesPerSec);
+ maxEventBytesPerSecValue.addSample(maxEventBytesPerSec);
var totalTraceBytesValue = new tr.v.Histogram(
tr.v.Unit.byName.sizeInBytes_smallerIsBetter, BYTE_BOUNDARIES);
- totalTraceBytesValue.add(totalTraceBytes);
+ totalTraceBytesValue.addSample(totalTraceBytes);
var biggestCategory = {
name: categoryWithMaxEventBytes,
« no previous file with comments | « tracing/tracing/metrics/system_health/webview_startup_metric.html ('k') | tracing/tracing/metrics/v8/execution_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698