Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tracing/tracing/metrics/blink/gc_metric.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/metrics/cpu_process_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/blink/gc_metric.html
diff --git a/tracing/tracing/metrics/blink/gc_metric.html b/tracing/tracing/metrics/blink/gc_metric.html
index b8091ac8055b742a7083d160d0b28326fb1caee4..a61dc51b22b6364cffab16ce8cea98124c2101bf 100644
--- a/tracing/tracing/metrics/blink/gc_metric.html
+++ b/tracing/tracing/metrics/blink/gc_metric.html
@@ -81,9 +81,9 @@ tr.exportTo('tr.metrics.blink', function() {
function createPercentage(numerator, denominator) {
var histogram = new tr.v.Histogram(percentage_biggerIsBetter);
if (denominator === 0)
- histogram.add(0);
+ histogram.addSample(0);
else
- histogram.add(numerator / denominator);
+ histogram.addSample(numerator / denominator);
return histogram;
}
@@ -98,7 +98,7 @@ tr.exportTo('tr.metrics.blink', function() {
function(name, events) {
var cpuDuration = createNumericForTopEventTime();
events.forEach(function(event) {
- cpuDuration.add(event.cpuDuration);
+ cpuDuration.addSample(event.cpuDuration);
});
values.addValue(new tr.v.NumericValue(name, cpuDuration));
}
@@ -116,7 +116,7 @@ tr.exportTo('tr.metrics.blink', function() {
function(name, events) {
var cpuDuration = createNumericForTopEventTime();
events.forEach(function(event) {
- cpuDuration.add(event.cpuDuration);
+ cpuDuration.addSample(event.cpuDuration);
});
values.addValue(new tr.v.NumericValue(name, cpuDuration));
}
@@ -179,10 +179,10 @@ tr.exportTo('tr.metrics.blink', function() {
inside = event.cpuDuration;
}
}
- cpuDuration.add(event.cpuDuration);
- insideIdle.add(inside);
- outsideIdle.add(event.cpuDuration - inside);
- idleDeadlineOverrun.add(overrun);
+ cpuDuration.addSample(event.cpuDuration);
+ insideIdle.addSample(inside);
+ outsideIdle.addSample(event.cpuDuration - inside);
+ idleDeadlineOverrun.addSample(overrun);
});
values.addValue(new tr.v.NumericValue(
name + '_idle_deadline_overrun',
« no previous file with comments | « no previous file | tracing/tracing/metrics/cpu_process_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698