Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: tracing/tracing/metrics/v8/execution_metric.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/tracing_metric.html ('k') | tracing/tracing/metrics/v8/gc_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/v8/execution_metric.html
diff --git a/tracing/tracing/metrics/v8/execution_metric.html b/tracing/tracing/metrics/v8/execution_metric.html
index b5fda6e0809870ed6a4ca85ed4a83ba4edd23c55..924dbf8910e16abadcda5b907c94ce859300eb2c 100644
--- a/tracing/tracing/metrics/v8/execution_metric.html
+++ b/tracing/tracing/metrics/v8/execution_metric.html
@@ -28,10 +28,10 @@ tr.exportTo('tr.metrics.v8', function() {
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, CUSTOM_BOUNDARIES);
for (var e of model.findTopmostSlicesNamed('V8.Execute')) {
- cpuTotalExecution.add(e.cpuDuration);
- wallTotalExecution.add(e.duration);
- cpuSelfExecution.add(e.cpuSelfTime);
- wallSelfExecution.add(e.selfTime);
+ cpuTotalExecution.addSample(e.cpuDuration);
+ wallTotalExecution.addSample(e.duration);
+ cpuSelfExecution.addSample(e.cpuSelfTime);
+ wallSelfExecution.addSample(e.selfTime);
}
values.addValue(new tr.v.NumericValue(
@@ -55,12 +55,12 @@ tr.exportTo('tr.metrics.v8', function() {
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, CUSTOM_BOUNDARIES);
for (var e of model.findTopmostSlicesNamed('V8.ParseLazyMicroSeconds')) {
- cpuSelfParseLazy.add(e.cpuSelfTime);
- wallSelfParseLazy.add(e.selfTime);
+ cpuSelfParseLazy.addSample(e.cpuSelfTime);
+ wallSelfParseLazy.addSample(e.selfTime);
}
for (var e of model.findTopmostSlicesNamed('V8.ParseLazy')) {
- cpuSelfParseLazy.add(e.cpuSelfTime);
- wallSelfParseLazy.add(e.selfTime);
+ cpuSelfParseLazy.addSample(e.cpuSelfTime);
+ wallSelfParseLazy.addSample(e.selfTime);
}
values.addValue(new tr.v.NumericValue(
@@ -78,8 +78,8 @@ tr.exportTo('tr.metrics.v8', function() {
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, CUSTOM_BOUNDARIES);
for (var e of model.findTopmostSlicesNamed('V8.CompileFullCode')) {
- cpuSelfCompileFullCode.add(e.cpuSelfTime);
- wallSelfCompileFullCode.add(e.selfTime);
+ cpuSelfCompileFullCode.addSample(e.cpuSelfTime);
+ wallSelfCompileFullCode.addSample(e.selfTime);
}
values.addValue(new tr.v.NumericValue(
@@ -100,8 +100,8 @@ tr.exportTo('tr.metrics.v8', function() {
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, CUSTOM_BOUNDARIES);
for (var e of model.findTopmostSlicesNamed('V8.CompileIgnition')) {
- cpuSelfCompileIgnition.add(e.cpuSelfTime);
- wallSelfCompileIgnition.add(e.selfTime);
+ cpuSelfCompileIgnition.addSample(e.cpuSelfTime);
+ wallSelfCompileIgnition.addSample(e.selfTime);
}
values.addValue(new tr.v.NumericValue(
@@ -132,10 +132,10 @@ tr.exportTo('tr.metrics.v8', function() {
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, CUSTOM_BOUNDARIES);
for (var e of model.findTopmostSlicesNamed('V8.RecompileSynchronous')) {
- cpuTotalRecompileSynchronous.add(e.cpuDuration);
- wallTotalRecompileSynchronous.add(e.duration);
- cpuTotalRecompileOverall.add(e.cpuDuration);
- wallTotalRecompileOverall.add(e.duration);
+ cpuTotalRecompileSynchronous.addSample(e.cpuDuration);
+ wallTotalRecompileSynchronous.addSample(e.duration);
+ cpuTotalRecompileOverall.addSample(e.cpuDuration);
+ wallTotalRecompileOverall.addSample(e.duration);
}
values.addValue(new tr.v.NumericValue(
@@ -149,10 +149,10 @@ tr.exportTo('tr.metrics.v8', function() {
for (var e of model.findTopmostSlicesNamed('V8.RecompileConcurrent')) {
- cpuTotalRecompileConcurrent.add(e.cpuDuration);
- wallTotalRecompileConcurrent.add(e.duration);
- cpuTotalRecompileOverall.add(e.cpuDuration);
- wallTotalRecompileOverall.add(e.duration);
+ cpuTotalRecompileConcurrent.addSample(e.cpuDuration);
+ wallTotalRecompileConcurrent.addSample(e.duration);
+ cpuTotalRecompileOverall.addSample(e.cpuDuration);
+ wallTotalRecompileOverall.addSample(e.duration);
}
values.addValue(new tr.v.NumericValue(
@@ -184,8 +184,8 @@ tr.exportTo('tr.metrics.v8', function() {
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, CUSTOM_BOUNDARIES);
for (var e of model.findTopmostSlicesNamed('V8.OptimizeCode')) {
- cpuTotalOptimizeCode.add(e.cpuDuration);
- wallTotalOptimizeCode.add(e.duration);
+ cpuTotalOptimizeCode.addSample(e.cpuDuration);
+ wallTotalOptimizeCode.addSample(e.duration);
}
values.addValue(new tr.v.NumericValue(
@@ -205,8 +205,8 @@ tr.exportTo('tr.metrics.v8', function() {
tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, CUSTOM_BOUNDARIES);
for (var e of model.findTopmostSlicesNamed('V8.DeoptimizeCode')) {
- cpuTotalDeoptimizeCode.add(e.cpuDuration);
- wallTotalDeoptimizeCode.add(e.duration);
+ cpuTotalDeoptimizeCode.addSample(e.cpuDuration);
+ wallTotalDeoptimizeCode.addSample(e.duration);
}
values.addValue(new tr.v.NumericValue(
« no previous file with comments | « tracing/tracing/metrics/tracing_metric.html ('k') | tracing/tracing/metrics/v8/gc_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698